linux-mips
[Top] [All Lists]

Re: [PATCH] net: meth: Add set_rx_mode hook to fix ICMPv6 neighbor disco

To: shemminger@vyatta.com
Subject: Re: [PATCH] net: meth: Add set_rx_mode hook to fix ICMPv6 neighbor discovery
From: David Miller <davem@davemloft.net>
Date: Tue, 27 Dec 2011 13:52:09 -0500 (EST)
Cc: kumba@gentoo.org, netdev@vger.kernel.org, linux-mips@linux-mips.org
In-reply-to: <20111227103408.01aad10e@nehalam.linuxnetplumber.net>
References: <4EED3A3D.9080503@gentoo.org> <4EF95247.7000403@gentoo.org> <20111227103408.01aad10e@nehalam.linuxnetplumber.net>
Sender: linux-mips-bounce@linux-mips.org
From: Stephen Hemminger <shemminger@vyatta.com>
Date: Tue, 27 Dec 2011 10:34:08 -0800

> On Tue, 27 Dec 2011 00:06:15 -0500
> Joshua Kinard <kumba@gentoo.org> wrote:
> 
>> @@ -95,7 +95,7 @@ struct mace_video {
>>   * Ethernet interface
>>   */
>>  struct mace_ethernet {
>> -    volatile unsigned long mac_ctrl;
>> +    volatile u64 mac_ctrl;
>>      volatile unsigned long int_stat;
>>      volatile unsigned long dma_ctrl;
>>      volatile unsigned long timer;
> 
> 
> This device driver writer needs to read:
>   Documentation/volatile-considered-harmful.txt

This driver has a lot of problems, some of which I've made Joshua aware of
already.

<Prev in Thread] Current Thread [Next in Thread>