[Top] [All Lists]

Re: [PATCH v2a] jump-label: initialize jump-label subsystem somewhat lat

To:, Linus Torvalds <>, Andrew Morton <>,, Jeremy Fitzhardinge <>, Peter Zijlstra <>
Subject: Re: [PATCH v2a] jump-label: initialize jump-label subsystem somewhat later
From: David Daney <>
Date: Mon, 19 Dec 2011 15:07:35 -0800
Cc:, Jason Baron <>, David Daney <>
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed;; s=gamma; h=message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:content-type:content-transfer-encoding; bh=YaiQwu1+uOsLwZXQ+JgvA7b9vleTNIWNeP9DIqLm1xs=; b=YAdam6Qpw7tFPQ7u5z2ELh2uhxQ893o4Y1Mw421tcIsIb4Q0KewiX0mpfPe8dcNlZx n120/exhBxb7BXgOZQdIRGUMmliT9lwT4B9SYoQQG/BZ9f98YllpvZfxo0PrGItuQs5K SOOZmJyduR5fO+omDi42n129MuxdH9d1L0T0k=
In-reply-to: <>
References: <>
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv: Gecko/20101027 Fedora/3.0.10-1.fc12 Thunderbird/3.0.10
On 12/14/2011 09:54 AM, David Daney wrote:
From: David Daney<>

commit 97ce2c88f9ad42e3c60a9beb9fca87abf3639faa
(jump-label: initialize jump-label subsystem much earlier) breaks MIPS.

The jump-label initialization does I-Cache flushing after modifying
code.  On MIPS this is done by calling through the function pointer
flush_icache_range().  This function pointer is initialized by

As things stand, we cannot be calling jump_label_init() until after
trap_init() completes, so we move the call down to satisfy this

Signed-off-by: David Daney<>

NACK to myself:

I now have a patch for MIPS that makes this one unnecessary.

David Daney


Sorry for spamming this out again, but Sergei keeps flagging my poor

Difference from v2: Fix grammar and spelling issues in changelog.  No
                     change to the patch.

Difference from v1: Move jump_label_init() up one so it is now before
                     mm_init() instead of after it.

  init/main.c |    3 +--
  1 files changed, 1 insertions(+), 2 deletions(-)

diff --git a/init/main.c b/init/main.c
index 217ed23..68ab12b 100644
--- a/init/main.c
+++ b/init/main.c
@@ -513,8 +513,6 @@ asmlinkage void __init start_kernel(void)
                   __stop___param - __start___param,

-       jump_label_init();
         * These use large bootmem allocations and must precede
         * kmem_cache_init()
@@ -524,6 +522,7 @@ asmlinkage void __init start_kernel(void)
+       jump_label_init();


<Prev in Thread] Current Thread [Next in Thread>