linux-mips
[Top] [All Lists]

Re: [PATCH V2 2/5] MTD: bcm63xxpart: make sure CFE and NVRAM partitions

To: Jonas Gorski <jonas.gorski@gmail.com>
Subject: Re: [PATCH V2 2/5] MTD: bcm63xxpart: make sure CFE and NVRAM partitions are at least 64K
From: Artem Bityutskiy <dedekind1@gmail.com>
Date: Mon, 19 Dec 2011 12:56:32 +0200
Cc: linux-mtd@lists.infradead.org, linux-mips@linux-mips.org, David Woodhouse <dwmw2@infradead.org>, Florian Fainelli <florian@openwrt.org>
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=message-id:subject:from:reply-to:to:cc:date:in-reply-to:references :content-type:x-mailer:mime-version; bh=hQjm1Gcjp1fqRLSRJqLgOWRNQMBxDN/qpFMd7MEvQV8=; b=qnxdtZdfzyr6sd92jEs87SoD8Wrx5Zh6pxsCBH9h+g0sLZwuWGsuPdYeplqHk+qvf4 2xxzgPN2LRLa+R63vzj/JVBT/6pOBG/nijV/ivM1zmzSJHRWHDBMu3pnXhnT4JYPzAsa QKLAOqNzrz1aEZLmaLHqpcR5jB6M/ohn/sUoo=
In-reply-to: <1324290964-14096-1-git-send-email-jonas.gorski@gmail.com>
References: <1324208821.17534.0.camel@sauron.fi.intel.com> <1324290964-14096-1-git-send-email-jonas.gorski@gmail.com>
Reply-to: dedekind1@gmail.com
Sender: linux-mips-bounce@linux-mips.org
On Mon, 2011-12-19 at 11:36 +0100, Jonas Gorski wrote:
> The CFE boot loader on BCM63XX platforms assumes itself and the NVRAM
> partition to be 64 KiB (or erase block sized, if larger).
> Ensure this assumption is also met when creating the partitions to
> prevent accidential erasure of CFE or NVRAM.
> 
> Signed-off-by: Jonas Gorski <jonas.gorski@gmail.com>

If someone creates a partition smaller than 64 KiB, then why it is
better to silently make it 64 KiB (and thus doing not what the user
asked to do and possibly confusing him), rather than returning an error
or just printing a warning?

-- 
Best Regards,
Artem Bityutskiy

Attachment: signature.asc
Description: This is a digitally signed message part

<Prev in Thread] Current Thread [Next in Thread>