linux-mips
[Top] [All Lists]

Re: [PATCH 2/5] MTD: bcm63xxpart: make sure CFE and NVRAM partitions are

To: Jonas Gorski <jonas.gorski@gmail.com>
Subject: Re: [PATCH 2/5] MTD: bcm63xxpart: make sure CFE and NVRAM partitions are at least 64K
From: Artem Bityutskiy <dedekind1@gmail.com>
Date: Sat, 17 Dec 2011 23:33:58 +0200
Cc: linux-mtd@lists.infradead.org, linux-mips@linux-mips.org, Artem Bityutskiy <Artem.Bityutskiy@intel.com>, David Woodhouse <dwmw2@infradead.org>, Florian Fainelli <florian@openwrt.org>
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=subject:from:reply-to:to:cc:date:in-reply-to:references :content-type:x-mailer:content-transfer-encoding:message-id :mime-version; bh=a9k7O5a7YT2N4ciHkWrtUzDK/JcFBYQHMdCvWw3Bqqs=; b=PT0RJ792wUfkrhfKfczxRbBGOYv3V+wfVJNaFgOC9TSQCzDrMMW8R9ModfkP6vXmWX DEhzFG7Emb2xCkpCumxOJbqrfG018KyBf2ivAXGS9CCtaR48QbGVAtPzkol/X6/ZENhx 5iDTZXIr4vJvnYAF96CPOqEVKeYN0fuDbTBRw=
In-reply-to: <1324126698-9919-3-git-send-email-jonas.gorski@gmail.com>
References: <1324126698-9919-1-git-send-email-jonas.gorski@gmail.com> <1324126698-9919-3-git-send-email-jonas.gorski@gmail.com>
Reply-to: dedekind1@gmail.com
Sender: linux-mips-bounce@linux-mips.org
On Sat, 2011-12-17 at 13:58 +0100, Jonas Gorski wrote:
> The CFE and NVRAM are always at least 64K big, so make sure their
> partitions are never smaller than this in case the flash has smaller
> erase sectors.
> 
> Signed-off-by: Jonas Gorski <jonas.gorski@gmail.com>

Not that I have any knowledge about BCM platform, but still, I think
it is good idea to explain why these partitions have to be at least
64KiB. Could you please do this, just for the sake of having good
commit messages?

Artem.


<Prev in Thread] Current Thread [Next in Thread>