linux-mips
[Top] [All Lists]

Re: [PATCH 2/5] MTD: bcm63xxpart: make sure CFE and NVRAM partitions are

To: Jonas Gorski <jonas.gorski@gmail.com>
Subject: Re: [PATCH 2/5] MTD: bcm63xxpart: make sure CFE and NVRAM partitions are at least 64K
From: Guillaume LECERF <glecerf@gmail.com>
Date: Sat, 17 Dec 2011 15:32:19 +0100
Cc: linux-mtd@lists.infradead.org, linux-mips@linux-mips.org, Artem Bityutskiy <Artem.Bityutskiy@intel.com>, David Woodhouse <dwmw2@infradead.org>, Florian Fainelli <florian@openwrt.org>
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:from:date :x-google-sender-auth:message-id:subject:to:cc:content-type :content-transfer-encoding; bh=Uyz5Z5u9EuyE3ZKkh505d5dTN2RzRZ2dtaXo57Arnhc=; b=skjtPkKcJu0eouwHZW+zJQUJaIp3B9XxrdIFR0ePYsn9/zGhVRoxqNn+L9g5gDWuZ5 EpXdrFFb8e1p59hZgz57m1GBsyZG8fjmibYkDXV7ksrkc2GARLTg4EU8o/O2+xLgPiVN XFWXIkro+D8B274lHeHmjcfzIlNmz2Hmd6tVk=
In-reply-to: <CAOiHx=km1TEy0r1zpk+iSiqHMfqR2qPmtJQA5RsuGKG09e60tQ@mail.gmail.com>
References: <1324126698-9919-1-git-send-email-jonas.gorski@gmail.com> <1324126698-9919-3-git-send-email-jonas.gorski@gmail.com> <CAJpamw5qTXwMC_HQXN+ehjxDDQ6GXT_-Kcfu8E7P5F2CnLqsZA@mail.gmail.com> <CAOiHx=km1TEy0r1zpk+iSiqHMfqR2qPmtJQA5RsuGKG09e60tQ@mail.gmail.com>
Sender: linux-mips-bounce@linux-mips.org
2011/12/17 Jonas Gorski <jonas.gorski@gmail.com>:
> The intention is to align the spareaddr to the next eraseblock (cfelen
> can be bigger than the erasesize). Maybe writing it as
>
>        spareaddr = roundup(cfelen + totallen, master->erasesize);
>
> would be cleaner.


Humm, you're right, forget my comment.
BTW I don't mind what syntax you chose.

Good job ;)


-- 
Guillaume LECERF
OpenBricks developer - www.openbricks.org

<Prev in Thread] Current Thread [Next in Thread>