| To: | Jesse Barnes <jbarnes@virtuousgeek.org> |
|---|---|
| Subject: | [PATCH 2/6] MIPS: PCI: use list_for_each_entry() for bus->devices traversal |
| From: | Bjorn Helgaas <bhelgaas@google.com> |
| Date: | Fri, 16 Dec 2011 15:31:39 -0700 |
| Cc: | linux-pci@vger.kernel.org, Ralf Baechle <ralf@linux-mips.org>, linux-mips@linux-mips.org |
| Dkim-signature: | v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=beta; h=subject:to:from:cc:date:message-id:in-reply-to:references :user-agent:mime-version:content-type:content-transfer-encoding; bh=4BxWnxDCJAZNF60EvREE2vUxAkMHsb8UoQ9rAhp2sW4=; b=bgGahfAY1fTpFrxW61aWR2nqd63KVZ4B7gOAQUkqBnbKn5ZQUD8lAEUzwd6FJrNFA9 1NYrzvmQgl9Imhmi4yiQ== |
| In-reply-to: | <20111216223043.5963.87534.stgit@bhelgaas.mtv.corp.google.com> |
| References: | <20111216223043.5963.87534.stgit@bhelgaas.mtv.corp.google.com> |
| Sender: | linux-mips-bounce@linux-mips.org |
| User-agent: | StGit/0.15 |
Replace open-coded list traversal with list_for_each_entry().
CC: Ralf Baechle <ralf@linux-mips.org>
CC: linux-mips@linux-mips.org
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
---
arch/mips/pci/pci.c | 5 +----
arch/mips/pmc-sierra/yosemite/ht-irq.c | 10 ----------
2 files changed, 1 insertions(+), 14 deletions(-)
diff --git a/arch/mips/pci/pci.c b/arch/mips/pci/pci.c
index 934862c..ae5e423 100644
--- a/arch/mips/pci/pci.c
+++ b/arch/mips/pci/pci.c
@@ -273,7 +273,6 @@ void __devinit pcibios_fixup_bus(struct pci_bus *bus)
{
/* Propagate hose info into the subordinate devices. */
- struct list_head *ln;
struct pci_dev *dev = bus->self;
if (pci_probe_only && dev &&
@@ -282,9 +281,7 @@ void __devinit pcibios_fixup_bus(struct pci_bus *bus)
pcibios_fixup_device_resources(dev, bus);
}
- for (ln = bus->devices.next; ln != &bus->devices; ln = ln->next) {
- dev = pci_dev_b(ln);
-
+ list_for_each_entry(dev, &bus->devices, bus_list) {
if ((dev->class >> 8) != PCI_CLASS_BRIDGE_PCI)
pcibios_fixup_device_resources(dev, bus);
}
diff --git a/arch/mips/pmc-sierra/yosemite/ht-irq.c
b/arch/mips/pmc-sierra/yosemite/ht-irq.c
index 86b98e9..62ead66 100644
--- a/arch/mips/pmc-sierra/yosemite/ht-irq.c
+++ b/arch/mips/pmc-sierra/yosemite/ht-irq.c
@@ -35,16 +35,6 @@
*/
void __init titan_ht_pcibios_fixup_bus(struct pci_bus *bus)
{
- struct pci_bus *current_bus = bus;
- struct pci_dev *devices;
- struct list_head *devices_link;
-
- list_for_each(devices_link, &(current_bus->devices)) {
- devices = pci_dev_b(devices_link);
- if (devices == NULL)
- continue;
- }
-
/*
* PLX and SPKT related changes go here
*/
|
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [PATCH 4/5] MIPS: BCM63XX: add RNG driver platform_device stub, Florian Fainelli |
|---|---|
| Next by Date: | linux-next: build failure after merge of the final tree (mips tree related), Stephen Rothwell |
| Previous by Thread: | [PATCH V5 0/4] MIPS: Add support for Loongson1B, Kelvin Cheung |
| Next by Thread: | linux-next: build failure after merge of the final tree (mips tree related), Stephen Rothwell |
| Indexes: | [Date] [Thread] [Top] [All Lists] |