Re: [PATCH 4/5] MIPS: BCM63XX: add RNG driver platform_device stub

[Florian Fainelli <florian@openwrt.org>]

Hello Sergei,

On 12/10/11 15:46, Sergei Shtylyov wrote:
> Hello.
>
> On 09-12-2011 23:01, Florian Fainelli wrote:
>
> > Signed-off-by: Florian Fainelli<florian@openwrt.org>
> [...]
>
> > diff --git a/arch/mips/bcm63xx/dev-trng.c b/arch/mips/bcm63xx/dev-trng.c
> > new file mode 100644
> > index 0000000..19ccfbf
> > --- /dev/null
> > +++ b/arch/mips/bcm63xx/dev-trng.c
> > @@ -0,0 +1,40 @@
> [...]
> > +static struct resource trng_resources[] = {
> > +    {
> > +        .start        = -1, /* filled at runtime */
> > +        .end        = -1, /* filled at runtime */
> > +        .flags        = IORESOURCE_MEM,
> > +    },
> > +};
> > +
> > +static struct platform_device bcm63xx_trng_device = {
> > +    .name        = "bcm63xx-trng",
> > +    .id        = 0,
>    Why not -1? Isn't there only single device of this sort?
There is a single device, I will fix that in a second version of the 
patchset.
--
Florian