linux-mips
[Top] [All Lists]

Re: [PATCH 4/5] MIPS: BCM63XX: add RNG driver platform_device stub

To: Sergei Shtylyov <sshtylyov@mvista.com>
Subject: Re: [PATCH 4/5] MIPS: BCM63XX: add RNG driver platform_device stub
From: Florian Fainelli <florian@openwrt.org>
Date: Fri, 16 Dec 2011 16:03:42 +0100
Cc: Matt Mackall <mpm@selenic.com>, Herbert Xu <herbert@gondor.apana.org.au>, ralf@linux-mips.org, linux-mips@linux-mips.org
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=sender:message-id:date:from:organization:user-agent:mime-version:to :cc:subject:references:in-reply-to:content-type :content-transfer-encoding; bh=SaA2YNdFsQvC0pqVQTohzWthVBlIcBLHNozXKssSb4M=; b=sJBVCz8rUzN7ft1NAH1gIcI2tnrVRYfTNpjTtISvFWUF6k/MP0fCO4dxEXZvQEmmcO /Zkig7cjDvfKCd8GnIl4Ux0LhTRhKdCyHSEb9I4KE4fLLk2MEcuCPH+ZEcKYgvdfLWaD QidC8EbUbuU+Qfyx3DLOIK+RWLcWfQ7bVjLyM=
In-reply-to: <4EE370D9.9090900@mvista.com>
Organization: OpenWrt
References: <1323457270-16330-1-git-send-email-florian@openwrt.org> <1323457270-16330-5-git-send-email-florian@openwrt.org> <4EE370D9.9090900@mvista.com>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:8.0) Gecko/20111124 Thunderbird/8.0
Hello Sergei,

On 12/10/11 15:46, Sergei Shtylyov wrote:
Hello.

On 09-12-2011 23:01, Florian Fainelli wrote:

Signed-off-by: Florian Fainelli<florian@openwrt.org>
[...]

diff --git a/arch/mips/bcm63xx/dev-trng.c b/arch/mips/bcm63xx/dev-trng.c
new file mode 100644
index 0000000..19ccfbf
--- /dev/null
+++ b/arch/mips/bcm63xx/dev-trng.c
@@ -0,0 +1,40 @@
[...]
+static struct resource trng_resources[] = {
+    {
+        .start        = -1, /* filled at runtime */
+        .end        = -1, /* filled at runtime */
+        .flags        = IORESOURCE_MEM,
+    },
+};
+
+static struct platform_device bcm63xx_trng_device = {
+    .name        = "bcm63xx-trng",
+    .id        = 0,

   Why not -1? Isn't there only single device of this sort?

There is a single device, I will fix that in a second version of the patchset.
--
Florian

<Prev in Thread] Current Thread [Next in Thread>