| To: | Peter Zijlstra <a.p.zijlstra@chello.nl> |
|---|---|
| Subject: | Re: [PATCH] jump-label: initialize jump-label subsystem somewhat later |
| From: | David Daney <david.daney@cavium.com> |
| Date: | Wed, 14 Dec 2011 09:17:05 -0800 |
| Cc: | David Daney <ddaney.cavm@gmail.com>, ralf@linux-mips.org, Linus Torvalds <torvalds@linux-foundation.org>, Andrew Morton <akpm@linux-foundation.org>, linux-mips@linux-mips.org, Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com>, linux-kernel@vger.kernel.org, Jason Baron <jbaron@redhat.com> |
| In-reply-to: | <1323881470.28489.51.camel@twins> |
| References: | <1323881315-23245-1-git-send-email-ddaney.cavm@gmail.com> <1323881470.28489.51.camel@twins> |
| Sender: | linux-mips-bounce@linux-mips.org |
| User-agent: | Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.15) Gecko/20101027 Fedora/3.0.10-1.fc12 Thunderbird/3.0.10 |
On 12/14/2011 08:51 AM, Peter Zijlstra wrote: On Wed, 2011-12-14 at 08:48 -0800, David Daney wrote:From: David Daney<david.daney@cavium.com> commit 97ce2c88f9ad42e3c60a9beb9fca87abf3639faa breaks MIPS. The jump-lable initialization does I-Cache flushing after modifying code. On MIPS this is done by calling through the function pointer flush_icache_range(). This function pointer is initialized mm_init(). Actually I misspoke, for MIPS we need jump_label_init() after trap_init(), not mm_init(). As things stand, we cannot be calling jump_label_init() until after mm_init() completes, so we move the call down to satisfy this constraint.I'm fine as long as it stays before sched_init(), which it does. Jeremy is this still early enough for you? Just tested a revised patch that moves it to between trap_init() and mm_init(), I propose that we do that instead. New patch in a couple of minutes. David Daney |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [PATCH] jump-label: initialize jump-label subsystem somewhat later, Peter Zijlstra |
|---|---|
| Next by Date: | [PATCH v2] jump-label: initialize jump-label subsystem somewhat later, David Daney |
| Previous by Thread: | Re: [PATCH] jump-label: initialize jump-label subsystem somewhat later, Peter Zijlstra |
| Next by Thread: | Re: [PATCH] jump-label: initialize jump-label subsystem somewhat later, Sergei Shtylyov |
| Indexes: | [Date] [Thread] [Top] [All Lists] |