| To: | David Daney <david.daney@cavium.com> |
|---|---|
| Subject: | Re: [Patch v2]: Fix ld pr11138 FAILures on mips*. |
| From: | Alan Modra <amodra@gmail.com> |
| Date: | Sat, 10 Dec 2011 11:09:28 +1030 |
| Cc: | binutils <binutils@sourceware.org>, Richard Sandiford <rdsandiford@googlemail.com>, Manuel Lauss <manuel.lauss@googlemail.com>, Debian MIPS <debian-mips@lists.debian.org>, linux-mips <linux-mips@linux-mips.org> |
| Dkim-signature: | v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=date:from:to:cc:subject:message-id:mail-followup-to:references :mime-version:content-type:content-disposition:in-reply-to :user-agent; bh=jWAfHx/dRsRHMMteNCfF82lDJM0BcfUbyIStnJ714LE=; b=LOmz/R4/lYxd525l/nYDvBOSjXzK0rUh95kdd6Dmjw2gvgF06sGIGL+J5qq1i9Rxm/ Q7bX0tjfB78C8uN2ndo7u0rs9Z+9uWwJg1D7NNC/3DFShZHJx0DlMRlHAN7uoe64pGTH CY3lVwLCeYcaQbiGHTFm+ivKZDzTNOIJB4JWo= |
| In-reply-to: | <4EE27012.5030508@cavium.com> |
| Mail-followup-to: | David Daney <david.daney@cavium.com>, binutils <binutils@sourceware.org>, Richard Sandiford <rdsandiford@googlemail.com>, Manuel Lauss <manuel.lauss@googlemail.com>, Debian MIPS <debian-mips@lists.debian.org>, linux-mips <linux-mips@linux-mips.org> |
| References: | <4EE27012.5030508@cavium.com> |
| Sender: | linux-mips-bounce@linux-mips.org |
| User-agent: | Mutt/1.5.20 (2009-06-14) |
On Fri, Dec 09, 2011 at 12:31:14PM -0800, David Daney wrote:
> * /elfxx-mips.c (mips_elf_link_hash_table.rld_value): Remove.
> (mips_elf_link_hash_table.rld_symbol): New field;
> (MIPS_ELF_RLD_MAP_SIZE): New macro.
> (_bfd_mips_elf_add_symbol_hook): Remember __rld_obj_head symbol
> in rld_symbol.
> (_bfd_mips_elf_create_dynamic_sections): Remember __rld_map symbol
> in rld_symbol.
> (_bfd_mips_elf_size_dynamic_sections): Set correct size for .rld_map.
> (_bfd_mips_elf_finish_dynamic_symbol): Remove .rld_map handling.
> (_bfd_mips_elf_finish_dynamic_sections): Use rld_symbol to
> calculate DT_MIPS_RLD_MAP value.
> (_bfd_mips_elf_link_hash_table_create): Initialize rld_symbol,
> quit initializing rld_value.
OK. Remove stray / in ChangeLog entry
> + s->size += MIPS_ELF_RLD_MAP_SIZE(output_bfd);
Fix formatting here.
> + dyn.d_un.d_ptr = s->output_section->vma + s->output_offset
> + + h->root.u.def.value;
And it's nice to write code that emacs auto-indent won't change, so
add parentheses
dyn.d_un.d_ptr = (s->output_section->vma + s->output_offset
+ h->root.u.def.value);
--
Alan Modra
Australia Development Lab, IBM
|
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [PATCH v2] ipc: provide generic compat versions of IPC syscalls, Arnd Bergmann |
|---|---|
| Next by Date: | Re: [Patch v2]: Fix ld pr11138 FAILures on mips*., David Daney |
| Previous by Thread: | [Patch v2]: Fix ld pr11138 FAILures on mips*., David Daney |
| Next by Thread: | Re: [Patch v2]: Fix ld pr11138 FAILures on mips*., David Daney |
| Indexes: | [Date] [Thread] [Top] [All Lists] |