linux-mips
[Top] [All Lists]

Re: [PATCH] MIPS: Add RTC support for loongson1B

To: zhzhl555@gmail.com
Subject: Re: [PATCH] MIPS: Add RTC support for loongson1B
From: Ralf Baechle <ralf@linux-mips.org>
Date: Thu, 8 Dec 2011 13:08:35 +0000
Cc: a.zummo@towertech.it, rtc-linux@googlegroups.com, linux-mips@linux-mips.org, linux-kernel@vger.kernel.org, keguang.zhang@gmail.com, wuzhangjin@gmail.com, r0bertz@gentoo.org
In-reply-to: <1322729078-6141-1-git-send-email-zhzhl555@gmail.com>
References: <1322729078-6141-1-git-send-email-zhzhl555@gmail.com>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mutt/1.5.21 (2010-09-15)
On Thu, Dec 01, 2011 at 04:44:38PM +0800, zhzhl555@gmail.com wrote:

> +     writel(t, SYS_TOYWRITE1);
> +     __asm__ volatile ("sync");
> +     c = 0x10000;
> +     while ((readl(SYS_COUNTER_CNTRL) & SYS_CNTRL_TS) && --c)
> +             usleep_range(1000, 3000);

Why the SYNC instruction?  This is an uncached write and on all MIPS CPUs
the SYNC instruction will only make sure the write has left the CPU's
write buffers.  There is no guarantee that by the time the SYNC has completed
the write has actually reached its destination.  If that is what you want,
read something from device.  Reads will only complete after all preceeding
writes have completed.

In this driver all instances of SYNC instructions are followed by polling
loops reading from the RTC which means all SYNCs should be unnecessary.

Or?

  Ralf

<Prev in Thread] Current Thread [Next in Thread>