linux-mips
[Top] [All Lists]

Re: [Patch]: Fix ld pr11138 FAILures on mips*.

To: binutils <binutils@sourceware.org>
Subject: Re: [Patch]: Fix ld pr11138 FAILures on mips*.
From: David Daney <david.daney@cavium.com>
Date: Tue, 06 Dec 2011 12:20:14 -0800
Cc: linux-mips <linux-mips@linux-mips.org>, Manuel Lauss <manuel.lauss@googlemail.com>, Debian MIPS <debian-mips@lists.debian.org>
In-reply-to: <20111206054018.GB21034@bubble.grove.modra.org>
References: <4EDD669F.30207@cavium.com> <20111206054018.GB21034@bubble.grove.modra.org>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.15) Gecko/20101027 Fedora/3.0.10-1.fc12 Thunderbird/3.0.10
On 12/05/2011 09:40 PM, Alan Modra wrote:
On Mon, Dec 05, 2011 at 04:49:35PM -0800, David Daney wrote:
The root cause of this is that the mips linker synthesizes a special
symbol "__RLD_MAP", and then sets MIPS_RLD_MAP to point to it.  When
a version script is present, this symbol gets versioned along with
all the rest, and when it is time to take its address, the symbol
can no longer be found as it has had version information appended to
its name.

Why not just change

        &&  (strcmp (name, "__rld_map") == 0
              || strcmp (name, "__RLD_MAP") == 0))

to

        &&  (strncmp (name, "__rld_map", 9) == 0
              || strncmp (name, "__RLD_MAP", 9) == 0))

in _bfd_mips_elf_finish_dynamic_symbol?  Perhaps the same for other
syms there too?

Because that doesn't work. Perhpas I should have been a bit more detailed in my description of what is happening (at least in one case).

If the version script contains something like:
{
        global: main;
        local: *;
};

Then "__RLD_MAP" gets hidden and we never see it in _bfd_mips_elf_finish_dynamic_symbol().

This hiding gets done precisely in _bfd_elf_link_assign_sym_version() after the version information is calculated. So as the patch stands, we bail out of _bfd_elf_link_assign_sym_version() before the symbol is hidden (or modified in any way).

It is possible that 'no_sym_version' is not the best name for the flag, but I think we really some sort of flag to exclude ABI symbols from being mangled in _bfd_elf_link_assign_sym_version().

David Daney


<Prev in Thread] Current Thread [Next in Thread>