linux-mips
[Top] [All Lists]

Re: [PATCH 3/3] MIPS: changes in VM core for adding THP

To: Rik van Riel <riel@redhat.com>
Subject: Re: [PATCH 3/3] MIPS: changes in VM core for adding THP
From: David Daney <ddaney.cavm@gmail.com>
Date: Tue, 29 Nov 2011 10:03:45 -0800
Cc: Andrea Arcangeli <aarcange@redhat.com>, Hillf Danton <dhillf@gmail.com>, Andrew Morton <akpm@linux-foundation.org>, Ralf Baechle <ralf@linux-mips.org>, linux-mips@linux-mips.org, linux-mm@kvack.org
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:content-type:content-transfer-encoding; bh=ZE2IVaCuqBJGT9mqBJl3NnoOo3mpVoPFLK6GvTOI4/8=; b=aBXQrL5wVdFMkVmbmMpnjguMCvHSr8EY2QetOmj4tB16m4kahhmkY+lw/4lgPHsgXD ICXK5r3rid2fiWALXawCWnYKQG79GrN8yh17aKbyGcpTGa2jRUVpzOCnGAlZSWgVq86J G90+U6y65swU8/RMk9KVhC8/egAWBTTLcxRsA=
In-reply-to: <4ED51B48.6020202@redhat.com>
References: <CAJd=RBB2gSCaJSsFfJXBg2zmgzNjXPAn8OakAZACNG0mv2D7nQ@mail.gmail.com> <20111126173151.GF8397@redhat.com> <4ED51B48.6020202@redhat.com>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.15) Gecko/20101027 Fedora/3.0.10-1.fc12 Thunderbird/3.0.10
On 11/29/2011 09:50 AM, Rik van Riel wrote:
On 11/26/2011 12:31 PM, Andrea Arcangeli wrote:
On Sat, Nov 26, 2011 at 10:43:15PM +0800, Hillf Danton wrote:
In VM core, window is opened for MIPS to use THP.

And two simple helper functions are added to easy MIPS a bit.

Signed-off-by: Hillf Danton<dhillf@gmail.com>
---

--- a/mm/Kconfig Thu Nov 24 21:12:00 2011
+++ b/mm/Kconfig Sat Nov 26 22:12:56 2011
@@ -307,7 +307,7 @@ config NOMMU_INITIAL_TRIM_EXCESS

config TRANSPARENT_HUGEPAGE
bool "Transparent Hugepage Support"
- depends on X86&& MMU
+ depends on MMU
select COMPACTION
help
Transparent Hugepages allows the kernel to use huge pages and

Then the build will break for all archs if they enable it, better to
limit the option to those archs that supports it.

Would it be an idea to define ARCH_HAVE_HUGEPAGE in the
arch specific Kconfig file and test against that in
mm/Kconfig ?


I think so, but it would probably be spelled ARCH_HAVE_TRANSPARENT_HUGEPAGE

The practice of putting 'depends on X86' in archecture independent Kconfigs should really be discouraged. It has a real feel of hackyness to it.

David Daney

<Prev in Thread] Current Thread [Next in Thread>