linux-mips
[Top] [All Lists]

Re: [PATCH 3/3] MIPS: changes in VM core for adding THP

To: Andrea Arcangeli <aarcange@redhat.com>
Subject: Re: [PATCH 3/3] MIPS: changes in VM core for adding THP
From: Rik van Riel <riel@redhat.com>
Date: Tue, 29 Nov 2011 12:50:00 -0500
Cc: Hillf Danton <dhillf@gmail.com>, Andrew Morton <akpm@linux-foundation.org>, David Daney <ddaney.cavm@gmail.com>, Ralf Baechle <ralf@linux-mips.org>, linux-mips@linux-mips.org, linux-mm@kvack.org
In-reply-to: <20111126173151.GF8397@redhat.com>
References: <CAJd=RBB2gSCaJSsFfJXBg2zmgzNjXPAn8OakAZACNG0mv2D7nQ@mail.gmail.com> <20111126173151.GF8397@redhat.com>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:7.0) Gecko/20110927 Thunderbird/7.0
On 11/26/2011 12:31 PM, Andrea Arcangeli wrote:
On Sat, Nov 26, 2011 at 10:43:15PM +0800, Hillf Danton wrote:
In VM core, window is opened for MIPS to use THP.

And two simple helper functions are added to easy MIPS a bit.

Signed-off-by: Hillf Danton<dhillf@gmail.com>
---

--- a/mm/Kconfig        Thu Nov 24 21:12:00 2011
+++ b/mm/Kconfig        Sat Nov 26 22:12:56 2011
@@ -307,7 +307,7 @@ config NOMMU_INITIAL_TRIM_EXCESS

  config TRANSPARENT_HUGEPAGE
        bool "Transparent Hugepage Support"
-       depends on X86&&  MMU
+       depends on MMU
        select COMPACTION
        help
          Transparent Hugepages allows the kernel to use huge pages and

Then the build will break for all archs if they enable it, better to
limit the option to those archs that supports it.

Would it be an idea to define ARCH_HAVE_HUGEPAGE in the
arch specific Kconfig file and test against that in
mm/Kconfig ?

--
All rights reversed

<Prev in Thread] Current Thread [Next in Thread>