linux-mips
[Top] [All Lists]

Re: [PATCH] MIPS: Add RTC support for loongson1B

To: zhzhl555@gmail.com
Subject: Re: [PATCH] MIPS: Add RTC support for loongson1B
From: Linus Walleij <linus.walleij@linaro.org>
Date: Tue, 22 Nov 2011 10:47:45 +0100
Cc: a.zummo@towertech.it, rtc-linux@googlegroups.com, linux-mips@linux-mips.org, linux-kernel@vger.kernel.org, ralf@linux-mips.org, keguang.zhang@gmail.com, wuzhangjin@gmail.com, r0bertz@gentoo.org
In-reply-to: <1321864620-8925-1-git-send-email-zhzhl555@gmail.com>
References: <1321864620-8925-1-git-send-email-zhzhl555@gmail.com>
Sender: linux-mips-bounce@linux-mips.org
On Mon, Nov 21, 2011 at 9:37 AM,  <zhzhl555@gmail.com> wrote:

> From: zhao zhang <zhzhl555@gmail.com>
>
> This patch add RTC support(TOY counter0) for loongson1B
> Signed-off-by: zhao zhang <zhzhl555@gmail.com>
(...)
> +       __raw_writel(v, SYS_TOYWRITE0);

Why are you using __raw_* accessors everywhere?
Is something wrong with just writel()/readl() on loongson?

When I look in arch/mips/include/asm/io.h they actually
seem to be #defined to their __raw_* counterparts anyway
so it cannot hurt.

Yours,
Linus Walleij

<Prev in Thread] Current Thread [Next in Thread>