linux-mips
[Top] [All Lists]

Re: [patch] hugetlb: remove dummy definitions of HPAGE_MASK and HPAGE_SI

To: Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: [patch] hugetlb: remove dummy definitions of HPAGE_MASK and HPAGE_SIZE
From: David Daney <ddaney.cavm@gmail.com>
Date: Mon, 21 Nov 2011 15:47:32 -0800
Cc: David Rientjes <rientjes@google.com>, Andrew Morton <akpm@linux-foundation.org>, linux-mips@linux-mips.org, ralf@linux-mips.org, linux-kernel@vger.kernel.org, David Daney <david.daney@cavium.com>, linux-arch@vger.kernel.org, Robin Holt <holt@sgi.com>
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:content-type:content-transfer-encoding; bh=Cj31HspUwcAs4T2RNOlPjQ69aCsHNW/cFaP4WArF30Q=; b=yAY2ZzcvbgC62hcepUjRWywommumaNQ8wq04MVBMDHoUVcINjPaT13TNNV6w7ChVFx JUKlyMjAcO8ZOMlA0Bi5ko194yL3KTqZlyke23aDeanQYwdLOnROcF7tkVRBs1HObmcv ae/tE4grkSyMFs4lUoUHfMzVb183o+NpYkeZk=
In-reply-to: <CA+55aFwZxqHfEOemj+OJNKCj2toqGf3rkK-9iuS39L7iZsoH1Q@mail.gmail.com>
References: <1321567050-13197-1-git-send-email-ddaney.cavm@gmail.com> <alpine.DEB.2.00.1111171520130.20133@chino.kir.corp.google.com> <alpine.DEB.2.00.1111171522131.20133@chino.kir.corp.google.com> <4ECACF68.3020701@gmail.com> <CA+55aFwZxqHfEOemj+OJNKCj2toqGf3rkK-9iuS39L7iZsoH1Q@mail.gmail.com>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.15) Gecko/20101027 Fedora/3.0.10-1.fc12 Thunderbird/3.0.10
Just to expand on this lovely topic...

On 11/21/2011 02:43 PM, Linus Torvalds wrote:
On Mon, Nov 21, 2011 at 2:23 PM, David Daney<ddaney.cavm@gmail.com>  wrote:

This whole comment strikes me as somewhat dishonest, as at the time David
Rientjes wrote it, he knew that there were dependencies on these symbols in
the linux-next tree.

Now we can add these:
+#define HPAGE_SHIFT    ({ BUG(); 0; })
+#define HPAGE_SIZE     ({ BUG(); 0; })
+#define HPAGE_MASK     ({ BUG(); 0; })

Hell no.

We don't do run-time BUG() things. No way, no how.


These symbols are on dead code paths, so they are eliminated by the compiler's Dead Code Elimination (DCE) optimizations, and the BUG() code never gets emitted to the final executable.

I agree that it is not the best thing to do, but given the current state of the art in build bug macros, it is the best we could have done.

What I think we need instead, and for which I will send a patch soon, is something like this:

extern void you_are_screwed() __attribute__ ((error("BUILD_BUG_ON_USED failed")));
#define BUILD_BUG_ON_USED() you_are_screwed()
#define HPAGE_SHIFT    ({ BUILD_BUG_ON_USED(); 0; })

This allows us to use the symbols in straight line C code without a ton of ugly #ifdefery, but give us build time error checking.

Thanks,
David Daney


If that #define cannot be used, then it damn well shouldn't be defined at all.

David's patch is clearly the right thing to do. Don't try to send me
the above kind of insane crap.

                      Linus



<Prev in Thread] Current Thread [Next in Thread>