| To: | David Daney <ddaney.cavm@gmail.com> |
|---|---|
| Subject: | Re: [patch] hugetlb: remove dummy definitions of HPAGE_MASK and HPAGE_SIZE |
| From: | David Rientjes <rientjes@google.com> |
| Date: | Mon, 21 Nov 2011 14:48:07 -0800 (PST) |
| Cc: | Andrew Morton <akpm@linux-foundation.org>, Linus Torvalds <torvalds@linux-foundation.org>, linux-mips@linux-mips.org, ralf@linux-mips.org, linux-kernel@vger.kernel.org, David Daney <david.daney@cavium.com>, linux-arch@vger.kernel.org, Robin Holt <holt@sgi.com> |
| Dkim-signature: | v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=beta; h=date:from:x-x-sender:to:cc:subject:in-reply-to:message-id :references:user-agent:mime-version:content-type; bh=YVXXq6XarjJVf+hMQMdm7tyO2LnWrSd1zSsiEsfAHdM=; b=c0/Fxa8UBLI29uVgQC4z6hx8dtojAdDZty44jsGbXB5uWeG5Ie9jm37Tl5414UAg8M UYgYLAr/MOTqODpf3M7A== |
| In-reply-to: | <4ECACF68.3020701@gmail.com> |
| References: | <1321567050-13197-1-git-send-email-ddaney.cavm@gmail.com> <alpine.DEB.2.00.1111171520130.20133@chino.kir.corp.google.com> <alpine.DEB.2.00.1111171522131.20133@chino.kir.corp.google.com> <4ECACF68.3020701@gmail.com> |
| Sender: | linux-mips-bounce@linux-mips.org |
| User-agent: | Alpine 2.00 (DEB 1167 2008-08-23) |
On Mon, 21 Nov 2011, David Daney wrote:
> > So, just remove the dummy and dangerous definitions since they are no
> > longer needed and reveals the correct dependencies. Tested on
> > architectures using the definitions with allyesconfig: x86 (even with
> > thp), hppa, mips, powerpc, s390, sh3, sh4, sparc, and sparc64, and
> > with defconfig on ia64.
> >
>
> This whole comment strikes me as somewhat dishonest, as at the time David
> Rientjes wrote it, he knew that there were dependencies on these symbols in
> the linux-next tree.
>
I was referring to Linus' tree at the time the patch was merged, not
linux-next. However, yes, I was aware of the build breakage it caused in
Ralf's mips tree and I sent a patch to fix that breakage to the mips
folks:
http://marc.info/?l=linux-mips&m=132175788803677
Thanks.
|
| Previous by Date: | Re: [patch] hugetlb: remove dummy definitions of HPAGE_MASK and HPAGE_SIZE, Linus Torvalds |
|---|---|
| Next by Date: | Re: [patch] hugetlb: remove dummy definitions of HPAGE_MASK and HPAGE_SIZE, David Daney |
| Previous by Thread: | Re: [patch] hugetlb: remove dummy definitions of HPAGE_MASK and HPAGE_SIZE, Linus Torvalds |
| Next by Thread: | [PATCH 0/6] Allow to register wireless MAC device on AR933X based boards, Gabor Juhos |
| Indexes: | [Date] [Thread] [Top] [All Lists] |