linux-mips
[Top] [All Lists]

Re: [PATCH RFC 1/5] scripts: Add sortextable to sort the kernel's except

To: Mike Frysinger <vapier@gentoo.org>
Subject: Re: [PATCH RFC 1/5] scripts: Add sortextable to sort the kernel's exception table.
From: David Daney <ddaney.cavm@gmail.com>
Date: Mon, 21 Nov 2011 10:25:36 -0800
Cc: linux-mips@linux-mips.org, ralf@linux-mips.org, linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, linux-embedded@vger.kernel.org, x86@kernel.org, David Daney <david.daney@cavium.com>
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:content-type:content-transfer-encoding; bh=tNTbazuYwIVS2dOw7ZwZwBJL51hHr1pg7RKOXQP4uk0=; b=a2A0OmIkh+eQ+lnbYzHP5r8WOUGKEzDPMrfHn4hHOpMNZ5lUZCJ3bsEITLxPX1Is3Y lwN2IWhsvibvglnuN2c3kKFDiK9Y76MdQMJIWKFJYH4GWXeeeG7Gq0C7uTWChuMJVDet 4+HZXM9mHV14pcVjTl749XGJu4Ltv5LKePAxs=
In-reply-to: <201111201822.13614.vapier@gentoo.org>
References: <1321645068-20475-1-git-send-email-ddaney.cavm@gmail.com> <1321645068-20475-2-git-send-email-ddaney.cavm@gmail.com> <201111201822.13614.vapier@gentoo.org>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.15) Gecko/20101027 Fedora/3.0.10-1.fc12 Thunderbird/3.0.10
On 11/20/2011 03:22 PM, Mike Frysinger wrote:
On Friday 18 November 2011 14:37:44 David Daney wrote:
--- /dev/null
+++ b/scripts/sortextable.c

+/*
+ * sortextable.c: Sort the kernel's exception table
+ *
+ * Copyright 2011 Cavium, Inc.
+ *
+ * Based on code taken from recortmcount.c which is:

seems like it'd be nice if the duplicate helper funcs were placed in a common
header file rather than copying&  pasting between them.


Yes, I may try to factor out some common code if we decide to move forward with the patch set.


+       switch (w2(ehdr->e_machine)) {
+       default:
+               fprintf(stderr, "unrecognized e_machine %d %s\n",
+                       w2(ehdr->e_machine), fname);
+               fail_file();
+               break;
+       case EM_386:
+       case EM_MIPS:
+       case EM_X86_64:
+               break;
+       }  /* end switch */

unlike recordmcount, this file doesn't do anything arch specific.  so let's just
delete this and be done.

Not really true at this point. We don't know the size or layout of the architecture specific exception table entries, likewise for CONFIG_ARCH_HAS_SORT_EXTABLE, we don't even know how to do the comparison.

I was trying to be a little conservative and only apply the build time sort to configurations that I could test.

David Daney

<Prev in Thread] Current Thread [Next in Thread>