[Top] [All Lists]

Re: [PATCH] MIPS: Get rid of some #ifdefery in arch/mips/mm/tlb-r4k.c

To: Sergei Shtylyov <>
Subject: Re: [PATCH] MIPS: Get rid of some #ifdefery in arch/mips/mm/tlb-r4k.c
From: David Daney <>
Date: Mon, 21 Nov 2011 10:16:08 -0800
Cc: David Daney <>, "" <>, "" <>, David Daney <>
In-reply-to: <>
References: <> <>
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv: Gecko/20101027 Fedora/3.0.10-1.fc12 Thunderbird/3.0.10
On 11/21/2011 02:31 AM, Sergei Shtylyov wrote:

On 19-11-2011 1:30, David Daney wrote:

From: David Daney<>

In the case of !CONFIG_HUGETLB_PAGE, in linux/hugetlb.h we have this

     Missed it?

Indeed, I could swear that I put '#define pmd_huge(x) 0' in that commit log, but it is not there. The string was even still highlighted in my editor. At this point I blame the 'git commit' command for erasing that line.

David Daney

The other huge page constants in the if(pmd_huge()) block are likewise
defined, so we can get rid of the #ifdef CONFIG_HUGETLB_PAGE an let
the compiler optimize this block away instead.  Doing this the code
has a much cleaner appearance.

Signed-off-by: David Daney<>

WBR, Sergei

<Prev in Thread] Current Thread [Next in Thread>