| To: | Sergei Shtylyov <sshtylyov@mvista.com> |
|---|---|
| Subject: | Re: [PATCH] MIPS: Get rid of some #ifdefery in arch/mips/mm/tlb-r4k.c |
| From: | David Daney <ddaney@caviumnetworks.com> |
| Date: | Mon, 21 Nov 2011 10:16:08 -0800 |
| Cc: | David Daney <ddaney.cavm@gmail.com>, "linux-mips@linux-mips.org" <linux-mips@linux-mips.org>, "ralf@linux-mips.org" <ralf@linux-mips.org>, David Daney <david.daney@cavium.com> |
| In-reply-to: | <4ECA2869.2000404@mvista.com> |
| References: | <1321651809-23395-1-git-send-email-ddaney.cavm@gmail.com> <4ECA2869.2000404@mvista.com> |
| Sender: | linux-mips-bounce@linux-mips.org |
| User-agent: | Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.15) Gecko/20101027 Fedora/3.0.10-1.fc12 Thunderbird/3.0.10 |
On 11/21/2011 02:31 AM, Sergei Shtylyov wrote: Hello. On 19-11-2011 1:30, David Daney wrote:From: David Daney<david.daney@cavium.com>In the case of !CONFIG_HUGETLB_PAGE, in linux/hugetlb.h we have this definition: Indeed, I could swear that I put '#define pmd_huge(x) 0' in that commit log, but it is not there. The string was even still highlighted in my editor. At this point I blame the 'git commit' command for erasing that line. David Daney The other huge page constants in the if(pmd_huge()) block are likewise defined, so we can get rid of the #ifdef CONFIG_HUGETLB_PAGE an let the compiler optimize this block away instead. Doing this the code has a much cleaner appearance.Signed-off-by: David Daney<david.daney@cavium.com>WBR, Sergei |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | [PATCH 8/8 v2] MIPS: BCM63XX: make board setup code register the spi platform device, Florian Fainelli |
|---|---|
| Next by Date: | Re: [PATCH RFC 1/5] scripts: Add sortextable to sort the kernel's exception table., David Daney |
| Previous by Thread: | Re: [PATCH] MIPS: Get rid of some #ifdefery in arch/mips/mm/tlb-r4k.c, Sergei Shtylyov |
| Next by Thread: | [PATCH] MIPS: ath79: Use kmemdup rather than duplicating its implementation, Thomas Meyer |
| Indexes: | [Date] [Thread] [Top] [All Lists] |