linux-mips
[Top] [All Lists]

Re: [PATCH V2] NET: MIPS: lantiq: return value of request_irq was not ha

To: John Crispin <blogic@openwrt.org>
Subject: Re: [PATCH V2] NET: MIPS: lantiq: return value of request_irq was not handled gracefully
From: Sergei Shtylyov <sshtylyov@mvista.com>
Date: Mon, 21 Nov 2011 18:36:07 +0300
Cc: Ralf Baechle <ralf@linux-mips.org>, linux-mips@linux-mips.org
In-reply-to: <1321882291-13062-1-git-send-email-blogic@openwrt.org>
References: <1321882291-13062-1-git-send-email-blogic@openwrt.org>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mozilla/5.0 (X11; Linux i686; rv:6.0) Gecko/20110812 Thunderbird/6.0
Hello.

On 11/21/2011 04:31 PM, John Crispin wrote:

The return values of request_irq() were not checked leading to the following
error message.

drivers/net/ethernet/lantiq_etop.c: In function 'ltq_etop_hw_init':
drivers/net/ethernet/lantiq_etop.c:368:15: warning: ignoring return value of 
'request_irq', declared with attribute warn_unused_result
drivers/net/ethernet/lantiq_etop.c:377:15: warning: ignoring return value of 
'request_irq', declared with attribute warn_unused_result

Signed-off-by: John Crispin<blogic@openwrt.org>
Acked-by: David S. Miller<davem@davemloft.net>
---
Changes in V2:
* drop IRQF_DISABLED

  This should have been noted in the patch description...

WBR, Sergei

<Prev in Thread] Current Thread [Next in Thread>