linux-mips
[Top] [All Lists]

Re: [PATCH v3 3/7] MIPS: ath79: make ath724x_pcibios_init visible for ex

To: René Bolldorf <xsecute@googlemail.com>
Subject: Re: [PATCH v3 3/7] MIPS: ath79: make ath724x_pcibios_init visible for external code
From: Ralf Baechle <ralf@linux-mips.org>
Date: Mon, 21 Nov 2011 14:31:43 +0000
Cc: Gabor Juhos <juhosg@openwrt.org>, Sergei Shtylyov <sshtylyov@mvista.com>, linux-mips@linux-mips.org
In-reply-to: <CAEWqx5_Zep8QwS2t32BpygbqXx0exE4kTsH07J=vW2zr7rVO_w@mail.gmail.com>
References: <1321825151-16053-1-git-send-email-juhosg@openwrt.org> <1321825151-16053-4-git-send-email-juhosg@openwrt.org> <4ECA25CD.3050902@mvista.com> <4ECA3BCD.3050407@openwrt.org> <CAEWqx5_Zep8QwS2t32BpygbqXx0exE4kTsH07J=vW2zr7rVO_w@mail.gmail.com>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mutt/1.5.21 (2010-09-15)
On Mon, Nov 21, 2011 at 02:58:50PM +0100, René Bolldorf wrote:

> The sob tag is only for persons that are involved in the development
> of the patch.
> 
> Acked-by: Rene Bolldorf <xsecute@googlemail.com>

Since the header file in question was taken from a patch that you had
signed off, it would have been acceptable for Gábor to add a SoB line
for you to this patch in addition to his own.

Documentation/SubmittinPatches defines the semantics of SoB as:

 < ------------ snip snap snop ----------- >

        Developer's Certificate of Origin 1.1

        By making a contribution to this project, I certify that:

        (a) The contribution was created in whole or in part by me and I
            have the right to submit it under the open source license
            indicated in the file; or

        (b) The contribution is based upon previous work that, to the best
            of my knowledge, is covered under an appropriate open source
            license and I have the right under that license to submit that
            work with modifications, whether created in whole or in part
            by me, under the same open source license (unless I am
            permitted to submit under a different license), as indicated
            in the file; or

        (c) The contribution was provided directly to me by some other
            person who certified (a), (b) or (c) and I have not modified
            it.

        (d) I understand and agree that this project and the contribution
            are public and that a record of the contribution (including all
            personal information I submit with it, including my sign-off) is
            maintained indefinitely and may be redistributed consistent with
            this project or the open source license(s) involved.

then you just add a line saying

        Signed-off-by: Random J Developer <random@developer.example.org>

 < ------------ snip snap snop ----------- >

I'm normally accept non-trivial patches with just a single SoB line though
I might ask for the original author(s)' SoB in some cases or might just
complain missing SoBs and apply a patch anyway if it's trivial which means
like 10 lines of not quite rocket science content.

  Ralf

<Prev in Thread] Current Thread [Next in Thread>