linux-mips
[Top] [All Lists]

Re: [PATCH RFC 1/5] scripts: Add sortextable to sort the kernel's except

To: David Daney <ddaney.cavm@gmail.com>
Subject: Re: [PATCH RFC 1/5] scripts: Add sortextable to sort the kernel's exception table.
From: Mike Frysinger <vapier@gentoo.org>
Date: Sun, 20 Nov 2011 18:22:11 -0500
Cc: linux-mips@linux-mips.org, ralf@linux-mips.org, linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, linux-embedded@vger.kernel.org, x86@kernel.org, David Daney <david.daney@cavium.com>
In-reply-to: <1321645068-20475-2-git-send-email-ddaney.cavm@gmail.com>
Organization: wh0rd.org
References: <1321645068-20475-1-git-send-email-ddaney.cavm@gmail.com> <1321645068-20475-2-git-send-email-ddaney.cavm@gmail.com>
Sender: linux-mips-bounce@linux-mips.org
User-agent: KMail/1.13.7 (Linux/3.1.1; KDE/4.6.5; x86_64; ; )
On Friday 18 November 2011 14:37:44 David Daney wrote:
> --- /dev/null
> +++ b/scripts/sortextable.c
>
> +/*
> + * sortextable.c: Sort the kernel's exception table
> + *
> + * Copyright 2011 Cavium, Inc.
> + *
> + * Based on code taken from recortmcount.c which is:

seems like it'd be nice if the duplicate helper funcs were placed in a common 
header file rather than copying & pasting between them.

> +     switch (w2(ehdr->e_machine)) {
> +     default:
> +             fprintf(stderr, "unrecognized e_machine %d %s\n",
> +                     w2(ehdr->e_machine), fname);
> +             fail_file();
> +             break;
> +     case EM_386:
> +     case EM_MIPS:
> +     case EM_X86_64:
> +             break;
> +     }  /* end switch */

unlike recordmcount, this file doesn't do anything arch specific.  so let's 
just 
delete this and be done.
-mike

Attachment: signature.asc
Description: This is a digitally signed message part.

<Prev in Thread] Current Thread [Next in Thread>