linux-mips
[Top] [All Lists]

[PATCH] MIPS: Alchemy: Use kmemdup rather than duplicating its implement

To: linux-mips@linux-mips.org, linux-kernel@vger.kernel.org
Subject: [PATCH] MIPS: Alchemy: Use kmemdup rather than duplicating its implementation
From: Thomas Meyer <thomas@m3y3r.de>
Date: Thu, 17 Nov 2011 23:43:40 +0100
Sender: linux-mips-bounce@linux-mips.org
The semantic patch that makes this change is available
in scripts/coccinelle/api/memdup.cocci.

Signed-off-by: Thomas Meyer <thomas@m3y3r.de>
---

diff -u -p a/arch/mips/alchemy/common/platform.c 
b/arch/mips/alchemy/common/platform.c
--- a/arch/mips/alchemy/common/platform.c 2011-11-07 19:37:22.596233458 +0100
+++ b/arch/mips/alchemy/common/platform.c 2011-11-08 11:02:32.915507198 +0100
@@ -307,13 +307,12 @@ static void __init alchemy_setup_macs(in
        if (alchemy_get_macs(ctype) < 1)
                return;
 
-       macres = kmalloc(sizeof(struct resource) * MAC_RES_COUNT, GFP_KERNEL);
+       macres = kmemdup(au1xxx_eth0_resources[ctype],
+                        sizeof(struct resource) * MAC_RES_COUNT, GFP_KERNEL);
        if (!macres) {
                printk(KERN_INFO "Alchemy: no memory for MAC0 resources\n");
                return;
        }
-       memcpy(macres, au1xxx_eth0_resources[ctype],
-              sizeof(struct resource) * MAC_RES_COUNT);
        au1xxx_eth0_device.resource = macres;
 
        i = prom_get_ethernet_addr(ethaddr);
@@ -329,13 +328,12 @@ static void __init alchemy_setup_macs(in
        if (alchemy_get_macs(ctype) < 2)
                return;
 
-       macres = kmalloc(sizeof(struct resource) * MAC_RES_COUNT, GFP_KERNEL);
+       macres = kmemdup(au1xxx_eth1_resources[ctype],
+                        sizeof(struct resource) * MAC_RES_COUNT, GFP_KERNEL);
        if (!macres) {
                printk(KERN_INFO "Alchemy: no memory for MAC1 resources\n");
                return;
        }
-       memcpy(macres, au1xxx_eth1_resources[ctype],
-              sizeof(struct resource) * MAC_RES_COUNT);
        au1xxx_eth1_device.resource = macres;
 
        ethaddr[5] += 1;        /* next addr for 2nd MAC */

<Prev in Thread] Current Thread [Next in Thread>
  • [PATCH] MIPS: Alchemy: Use kmemdup rather than duplicating its implementation, Thomas Meyer <=