linux-mips
[Top] [All Lists]

Re: [PATCH 4/7] MIPS: ath79: add a common PCI registration function

To: Gabor Juhos <juhosg@openwrt.org>
Subject: Re: [PATCH 4/7] MIPS: ath79: add a common PCI registration function
From: René Bolldorf <xsecute@googlemail.com>
Date: Fri, 18 Nov 2011 19:58:58 +0100
Cc: Ralf Baechle <ralf@linux-mips.org>, linux-mips@linux-mips.org
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; bh=iViyLXEmOT0bZ0vX7SiYow+FtA8MBOxkN83r57rGAzM=; b=L63UnFItWIkw2fabsynDeQJteC8MpCpX6JS6IrIDYq7PGU1fQhMnDrx3kG8PZSdJK+ YplyAjFEXxzMROcLkIlVeBhzV1uZZL5k+T28yr1mMVpnvgx6coV0+hF+F3gTuQeKeUM5 mR7Wavejh4KVHA4JJWtIvJdO7AGclgzByCwWU=
In-reply-to: <4EC6AA03.2010805@openwrt.org>
References: <1321629720-29035-1-git-send-email-juhosg@openwrt.org> <1321629720-29035-4-git-send-email-juhosg@openwrt.org> <CAEWqx59XzDyGWi7q-PYjiXx7t1Jinoz8ygypbk65CmD+zcyW2g@mail.gmail.com> <4EC6A6E3.8040806@openwrt.org> <CAEWqx5_kuqeoHz=iNq5vDUX92zboBVksZ4JsyyEwk4tTaND77A@mail.gmail.com> <4EC6AA03.2010805@openwrt.org>
Sender: linux-mips-bounce@linux-mips.org
2011/11/18 Gabor Juhos <juhosg@openwrt.org>:
> 2011.11.18. 19:44 keltezéssel, René Bolldorf írta:
>> 2011/11/18 Gabor Juhos <juhosg@openwrt.org>:
>>> 2011.11.18. 19:32 keltezéssel, René Bolldorf írta:
>>>> On Fri, Nov 18, 2011 at 4:21 PM, Gabor Juhos <juhosg@openwrt.org> wrote:
>>>>> The current code unconditionally registers the AR724X
>>>>> specific PCI controller, even if the kernel is running
>>>>> on a different SoC.
>>>>>
>>>> This is not true, take a look in the ath79 Kconfig file...
>>>
>>> Well, it is true. If you have the Ubiquiti board selected, that will allow 
>>> you
>>> to select the PCI code to be built. If you select the PCI code as well, then
>>> pci-ath724x.c will be compiled into the kernel. Due to the nature of the
>>> 'arch_initcall' macro the PCI controller always gets registered. If you have
>>> another board selected along with the Ubiquiti, and you are trying to run 
>>> the
>>> kernel on the other board, the PCI controller will be registered on that as 
>>> well.
>>>
>>> -Gabor
>>>
>>
>> Apologies again, got a thinko :)
>
> No problem. BTW, you forgot to reply to all again. ;)
>
> -Gabor
>

Well, I should change my settings....

<Prev in Thread] Current Thread [Next in Thread>