linux-mips
[Top] [All Lists]

Re: [PATCH] hugetlb: Provide a default HPAGE_SHIFT if !CONFIG_HUGETLB_PA

To: David Daney <ddaney.cavm@gmail.com>
Subject: Re: [PATCH] hugetlb: Provide a default HPAGE_SHIFT if !CONFIG_HUGETLB_PAGE
From: David Rientjes <rientjes@google.com>
Date: Wed, 16 Nov 2011 13:32:04 -0800 (PST)
Cc: linux-mips@linux-mips.org, ralf@linux-mips.org, William Irwin <wli@holomorphy.com>, Andrew Morton <akpm@linux-foundation.org>, linux-kernel@vger.kernel.org, David Daney <david.daney@cavium.com>
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=beta; h=date:from:x-x-sender:to:cc:subject:in-reply-to:message-id :references:user-agent:mime-version:content-type; bh=roUnNzgnGVGUp1xRyhgei733Wc7Apl3oM689quOg67E=; b=eke9s63eJHDIZycW+f7ikvEYNbHCHb2Xu9cBENNAwPDpJlz6IBWlkA2WJgqmWPuj5w x3keoUgbC6fBUJ6A1cAA==
In-reply-to: <1321472611-13283-1-git-send-email-ddaney.cavm@gmail.com>
References: <1321472611-13283-1-git-send-email-ddaney.cavm@gmail.com>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Alpine 2.00 (DEB 1167 2008-08-23)
On Wed, 16 Nov 2011, David Daney wrote:

> From: David Daney <david.daney@cavium.com>
> 
> This is required now to get MIPS kernels to compile with
> !CONFIG_HUGETLB_PAGE.
> 

Why?  Apparently there's some config option you've enabled that is causing 
it to fail but I can't find it.  defconfig works fine on my mips 
crosscompiler and allyesconfig is borked already in other ways.

This is definitely the wrong fix, anyway, and it would require a change to 
arch/mips/include/asm/page.h instead since it's localized to mips, so 
nack.

> Signed-off-by: David Daney <david.daney@cavium.com>
> ---
>  include/linux/hugetlb.h |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/include/linux/hugetlb.h b/include/linux/hugetlb.h
> index 19644e0..746d543 100644
> --- a/include/linux/hugetlb.h
> +++ b/include/linux/hugetlb.h
> @@ -113,6 +113,7 @@ static inline void copy_huge_page(struct page *dst, 
> struct page *src)
>  #ifndef HPAGE_MASK
>  #define HPAGE_MASK   PAGE_MASK               /* Keep the compiler happy */
>  #define HPAGE_SIZE   PAGE_SIZE
> +#define HPAGE_SHIFT  PAGE_SHIFT
>  #endif
>  
>  #endif /* !CONFIG_HUGETLB_PAGE */

<Prev in Thread] Current Thread [Next in Thread>