linux-mips
[Top] [All Lists]

Re: [PATCH 1/2] Initial PCI support for Atheros 724x SoCs.

To: Rene Bolldorf <xsecute@googlemail.com>
Subject: Re: [PATCH 1/2] Initial PCI support for Atheros 724x SoCs.
From: Manuel Lauss <manuel.lauss@googlemail.com>
Date: Wed, 16 Nov 2011 20:50:51 +0100
Cc: Ralf Baechle <ralf@linux-mips.org>, linux-mips@linux-mips.org, linux-kernel@vger.kernel.org
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=gamma; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type:content-transfer-encoding; bh=HjzCm+trlPzkD9bmrh7jrImO5ZytGP+DtIVacgGYy/I=; b=pSTwbHiZE7Q95eKvGPZ6R0Fnlaf8XsT1x0pwfPd2d7o3mtWsRB3EBR+xR1gVy1GhM4 NoSV9J+iuRLRH2z27/SQKBHDw/OzHCl9/0pBFsf1wF76ByDINnJ1ysB7IsCKNEJKsnTy lQ8+0WKh39rM8R8lorbOmfm+qdk7FnyuWhKF8=
In-reply-to: <1321440940-20246-2-git-send-email-xsecute@googlemail.com>
References: <1321440940-20246-1-git-send-email-xsecute@googlemail.com> <1321440940-20246-2-git-send-email-xsecute@googlemail.com>
Sender: linux-mips-bounce@linux-mips.org
Howdy,

On Wed, Nov 16, 2011 at 11:55 AM, Rene Bolldorf <xsecute@googlemail.com> wrote:
> Signed-off-by: Rene Bolldorf <xsecute@googlemail.com>
> ---
>  arch/mips/pci/Makefile      |    1 +
>  arch/mips/pci/ops-ath724x.c |  109 
> +++++++++++++++++++++++++++++++++++++++++++
>  arch/mips/pci/pci-ath724x.c |   45 ++++++++++++++++++

Why don't you just merge ops-ath724x.c into pci-ath724x.c?  (the only
place where its
contents are referenced)


> diff --git a/arch/mips/pci/ops-ath724x.c b/arch/mips/pci/ops-ath724x.c
> new file mode 100644
> index 0000000..bd3cf15
> --- /dev/null
> +++ b/arch/mips/pci/ops-ath724x.c
> @@ -0,0 +1,109 @@
[...]
> +static int ath724x_pci_read(struct pci_bus *bus, unsigned int devfn, int 
> where,
> +                           int size, uint32_t *value)
> +{
> +       unsigned long flags, addr, tval, mask;
> +
> +       if(devfn)
> +               return PCIBIOS_DEVICE_NOT_FOUND;
> +
> +       if(where & (size - 1))
> +               return PCIBIOS_BAD_REGISTER_NUMBER;

Please run both patches through checkpatch once and fix up the
codingstyle issues it
will complain about (like the two above).


Thanks,
        Manuel Lauss

<Prev in Thread] Current Thread [Next in Thread>