linux-mips
[Top] [All Lists]

[PATCH V2 2/6] MIPS: lantiq: fix cmdline parsing

To: Ralf Baechle <ralf@linux-mips.org>
Subject: [PATCH V2 2/6] MIPS: lantiq: fix cmdline parsing
From: John Crispin <blogic@openwrt.org>
Date: Wed, 16 Nov 2011 15:28:38 +0100
Cc: linux-mips@linux-mips.org, John Crispin <blogic@openwrt.org>, Thomas Langer <thomas.langer@lantiq.com>
In-reply-to: <1321453722-2689-1-git-send-email-blogic@openwrt.org>
References: <1321453722-2689-1-git-send-email-blogic@openwrt.org>
Sender: linux-mips-bounce@linux-mips.org
The code tested if the KSEG1 mapped address of argv was != 0. We need to use
CPHYSADDR instead to make the conditional actually work.

Signed-off-by: Thomas Langer <thomas.langer@lantiq.com>
Signed-off-by: John Crispin <blogic@openwrt.org>
---
 arch/mips/lantiq/prom.c |    6 ++++--
 1 files changed, 4 insertions(+), 2 deletions(-)

diff --git a/arch/mips/lantiq/prom.c b/arch/mips/lantiq/prom.c
index e3b1e25..acb8921 100644
--- a/arch/mips/lantiq/prom.c
+++ b/arch/mips/lantiq/prom.c
@@ -49,10 +49,12 @@ static void __init prom_init_cmdline(void)
        char **argv = (char **) KSEG1ADDR(fw_arg1);
        int i;
 
+       arcs_cmdline[0] = '\0';
+
        for (i = 0; i < argc; i++) {
-               char *p = (char *)  KSEG1ADDR(argv[i]);
+               char *p = (char *) KSEG1ADDR(argv[i]);
 
-               if (p && *p) {
+               if (CPHYSADDR(p) && *p) {
                        strlcat(arcs_cmdline, p, sizeof(arcs_cmdline));
                        strlcat(arcs_cmdline, " ", sizeof(arcs_cmdline));
                }
-- 
1.7.7.1


<Prev in Thread] Current Thread [Next in Thread>