linux-mips
[Top] [All Lists]

Re: [PATCH] Kbuild: append missing-syscalls to the default target list

To: Michal Marek <mmarek@suse.cz>
Subject: Re: [PATCH] Kbuild: append missing-syscalls to the default target list
From: David Daney <ddaney.cavm@gmail.com>
Date: Tue, 08 Nov 2011 10:21:39 -0800
Cc: Ralf Baechle <ralf@linux-mips.org>, Arnaud Lacombe <lacombar@gmail.com>, "linux-kbuild@vger.kernel.org" <linux-kbuild@vger.kernel.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, "linux-mips@linux-mips.org" <linux-mips@linux-mips.org>, "Daney, David" <David.Daney@caviumnetworks.com>
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:content-type; bh=ryrbmiv+afOZO7SPUuWyex/2HtB9+M6wHIx7TAJ4xms=; b=CSrWJM8H5YB4ePJ5S28Me5TuS3A00dVIYAaPDlVRU9zruC3L3uZ141Wkd6X07XW5T9 32lvvbZGAC8oNvaiU6cdPs9MuKjzeX/HXX2j8mff+DSwNsyttDQ1RYS0ANWy9dd4yw9x vF5rsJuJR0d3yPZOBsA1SA4The6Plww0ub8pg=
In-reply-to: <4EB8E75D.1010706@suse.cz>
References: <1314234210-11090-1-git-send-email-lacombar@gmail.com> <4E69FEC9.2080204@suse.cz> <CACqU3MUFyn_jh2pN4GLENqcGVUzAwcMJUR_WLY2EtqOhMheceQ@mail.gmail.com> <20111101232233.GA32441@sepie.suse.cz> <20111107204448.GA9949@linux-mips.org> <20111107211900.GB6264@sepie.suse.cz> <20111107233330.GA26705@linux-mips.org> <4EB8E75D.1010706@suse.cz>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.15) Gecko/20101027 Fedora/3.0.10-1.fc12 Thunderbird/3.0.10
On 11/08/2011 12:25 AM, Michal Marek wrote:
On 8.11.2011 00:33, Ralf Baechle wrote:
On Mon, Nov 07, 2011 at 10:19:00PM +0100, Michal Marek wrote:

Wild guess - does this patch help?


diff --git a/Kbuild b/Kbuild
index 4caab4f..77c191a 100644
--- a/Kbuild
+++ b/Kbuild
@@ -94,7 +94,7 @@ targets += missing-syscalls
  quiet_cmd_syscalls = CALL    $<
        cmd_syscalls = $(CONFIG_SHELL) $<  $(CC) $(c_flags)

-missing-syscalls: scripts/checksyscalls.sh $(offsets-file) FORCE
+missing-syscalls: scripts/checksyscalls.sh $(offsets-file) $(bounds-file) FORCE
        $(call cmd,syscalls)

  # Keep these two files during make clean

No, it didn't.

If not, please attach logs of make V=1 with clean Linus' tree and with
5f7efb4c6da9f90cb306923ced2a6494d065a595 reverted.

$ git checkout 31555213f03bca37d2c02e10946296052f4ecfcd
$ git revert 5f7efb4c6da9f90cb306923ced2a6494d065a595
$ make ARCH=mips ip27_defconfig
$ make ARCH=mips V=1 2>&1 | tee log

Thanks, can you also post a log without the revert?


The problem is that compiler options meant to be used only for the compiling done by scripts/checksyscalls.sh are now leaking into the compilation of other parts of the kernel (asm-offsets.c), where they wreak havoc.

Something like the attached is what I think needs to be done.

David Daney

Attachment: 0001-kbuild-Fix-missing-system-calls-check-on-mips.patch
Description: Text document

<Prev in Thread] Current Thread [Next in Thread>