linux-mips
[Top] [All Lists]

Re: [PATCH] MIPS: Add fast get_user_pages

To: Ralf Baechle <ralf@linux-mips.org>
Subject: Re: [PATCH] MIPS: Add fast get_user_pages
From: Hillf Danton <dhillf@gmail.com>
Date: Tue, 8 Nov 2011 20:17:27 +0800
Cc: David Daney <david.daney@cavium.com>, linux-mips@linux-mips.org
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; bh=1Cy5F8i0WtgjUy585/dOkHAW7K2Ti9dD/ThHNqzMa4Q=; b=A3O7H0019g7etFPQDbQJiPMzBi1k7ODkaSH/5YrtXuLVxtQOq9ssFepWiG48+Fj2fR KcbpWfjbsGNp/L3D7EDd2VBvn+gly5Kf47toKanDIuFgez8DF4mmTB03xNByL6ifRxSo +tU+KcSW0B8GjG3fXd2hiBHw4PMkpk29igZS0=
In-reply-to: <20111107120752.GA5142@linux-mips.org>
References: <CAJd=RBC=_+qAnbTaYXgTOoiVdfgppRt-rBs4cnKoZKxHD14nuw@mail.gmail.com> <20111104151603.GB13043@linux-mips.org> <20111107120752.GA5142@linux-mips.org>
Sender: linux-mips-bounce@linux-mips.org
On Mon, Nov 7, 2011 at 8:07 PM, Ralf Baechle <ralf@linux-mips.org> wrote:
>
> Hitting this one in a non-hugepage build of upstream-sfr:
>
>  CC      arch/mips/mm/gup.o
> arch/mips/mm/gup.c:70:51: error: redefinition of ‘get_huge_page_tail’
> include/linux/mm.h:379:51: note: previous definition of ‘get_huge_page_tail’ 
> was here
> make[2]: *** [arch/mips/mm/gup.o] Error 1
> make[1]: *** [arch/mips/mm] Error 2
> make: *** [arch/mips] Error 2
>
> I fixed this one up by removing the local definition of get_huge_page_tail
> but you may want to re-test.
>

Hi Ralf,

It is my fault. While preparing the patch, Andrea shared the function in
parallel, and I missed his update in linux/mm.h.

thp: share get_huge_page_tail()
author          Andrea Arcangeli <aarcange@redhat.com>  
                Wed, 2 Nov 2011 20:37:36 +0000 (13:37 -0700)
committer       Linus Torvalds <torvalds@linux-foundation.org>  
                Wed, 2 Nov 2011 23:06:58 +0000 (16:06 -0700)
commit          b35a35b556f5e6b7993ad0baf20173e75c09ce8c


Test will be rechecked soon, and thanks for your fixup.

Best regards

Hillf

<Prev in Thread] Current Thread [Next in Thread>