linux-mips
[Top] [All Lists]

Re: [PATCH] MIPS: Add fast get_user_pages

To: Hillf Danton <dhillf@gmail.com>
Subject: Re: [PATCH] MIPS: Add fast get_user_pages
From: Ralf Baechle <ralf@linux-mips.org>
Date: Fri, 4 Nov 2011 15:16:03 +0000
Cc: David Daney <david.daney@cavium.com>, linux-mips@linux-mips.org
In-reply-to: <CAJd=RBC=_+qAnbTaYXgTOoiVdfgppRt-rBs4cnKoZKxHD14nuw@mail.gmail.com>
References: <CAJd=RBC=_+qAnbTaYXgTOoiVdfgppRt-rBs4cnKoZKxHD14nuw@mail.gmail.com>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mutt/1.5.21 (2010-09-15)
On Fri, Oct 28, 2011 at 09:26:23PM +0800, Hillf Danton wrote:

When we were chasing the TLB crash recently for a while I was suspecting
the default get_user_fast implementation so I ported gup.c from x86 but I
never really finished it, so thanks for ridding me of one item from my
to do list.

This probably wants some more testing in particular on 32-bit systems with
64-bit pagetables such as some Alchemy configurations or 32-bit kernels
on Sibyte systems.

I fixed up a reject in arch/mips/mm/Makefile due to whitespace differences
and queued the patch for 3.3.

Have you made any benchmarks of the new gup.c?

Thanks,

  Ralf

<Prev in Thread] Current Thread [Next in Thread>