linux-mips
[Top] [All Lists]

Re: [PATCH] MIPS: Keep TLB cache hot while flushing

To: David Daney <ddaney.cavm@gmail.com>
Subject: Re: [PATCH] MIPS: Keep TLB cache hot while flushing
From: Ralf Baechle <ralf@linux-mips.org>
Date: Fri, 4 Nov 2011 14:56:27 +0000
Cc: Hillf Danton <dhillf@gmail.com>, linux-mips@linux-mips.org
In-reply-to: <4EAAD55D.4070106@gmail.com>
References: <CAJd=RBAQpea=wr2Nv6U1yRAH1bwaCvMxpnjfnKdhzAN3mtbK7A@mail.gmail.com> <4EAAD55D.4070106@gmail.com>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mutt/1.5.21 (2010-09-15)
On Fri, Oct 28, 2011 at 09:16:29AM -0700, David Daney wrote:

> >If we only flush the TLB of the given huge page, the TLB cache remains hot 
> >for
> >the relevant mm as it is, and less will be refilled after flush, huge or not.
> >
> >As always all comments and ideas welcome.
> >
> 
> I haven't tested it, but it looks correct.  When I wrote the
> original flush_tlb_mm(), I was in a hurry and was more concerned
> about maintaining TLB consistency, rather than performance.

Yes, looks sane and like an obvious performance improvment.  but as always
with TLB stuff I'm paranoid so I've applied this to my 3.3 queue for it to
be tested well.

Hillf, do you have any benchmark numbers for this?

Thanks folks!

  Ralf

<Prev in Thread] Current Thread [Next in Thread>