linux-mips
[Top] [All Lists]

Re: [PATCH RFC 4/8] mips: implement syscall restart generically

To: Ralf Baechle <ralf@linux-mips.org>
Subject: Re: [PATCH RFC 4/8] mips: implement syscall restart generically
From: Jonas Bonn <jonas.bonn@gmail.com>
Date: Fri, 4 Nov 2011 10:50:44 +0100
Cc: Jonas Bonn <jonas@southpole.se>, linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, linux-mips@linux-mips.org
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; bh=kmARUsjmOr0VwO16bEVSzMQb//EInf3ygbzHhfDWkxE=; b=OdKMGGF4WR6z9RmIAL1OR2NkjAvXYQH0e2o0mr+jfEsu+QYncZeYfKHKAvqeU/PunO UmYRPKCJdNI3Q4Af38gkWz05VyDxkGp94KxW/KnHw3KIObYzdXN2ZsOId56+wc+QOYqb RqcNiLisKDlYpOm5dxHxY1OESce/BuUOkP5W0=
In-reply-to: <20111104093222.GA1633@linux-mips.org>
References: <cover.1319364492.git.jonas@southpole.se> <04ce50ed7e9e9a949a3c0b447c3aec0a8c6face4.1319364492.git.jonas@southpole.se> <20111104093222.GA1633@linux-mips.org>
Sender: linux-mips-bounce@linux-mips.org
On 4 November 2011 10:32, Ralf Baechle <ralf@linux-mips.org> wrote:
>
> Nice cleanup.
>
> Any reason why you add empty version of syscall_get_arguments and
> syscall_set_version?  A non-functional version that causes a silent
> failure is way worse than something that fails at compile time.

Good point... I'll remove those empty functions for this patch series
and look into doing a proper implementation for them later.

Thanks for the review.

/Jonas

<Prev in Thread] Current Thread [Next in Thread>