linux-mips
[Top] [All Lists]

Re: [PATCH] staging/octeon: Software should check the checksum of no tcp

To: David Daney <david.daney@cavium.com>
Subject: Re: [PATCH] staging/octeon: Software should check the checksum of no tcp/udp packets
From: Greg KH <greg@kroah.com>
Date: Mon, 26 Sep 2011 17:51:27 -0700
Cc: rongqing.li@windriver.com, netdev@vger.kernel.org, ralf@linux-mips.org, David Miller <davem@davemloft.net>, linux-mips@linux-mips.org
Dkim-signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d= messagingengine.com; h=date:from:to:cc:subject:message-id :references:mime-version:content-type:in-reply-to; s=smtpout; bh=yH9gJEw+pngUpI7hHDojGaXrWBA=; b=aZhb/rxwU1VMdLvHNlLfxJ1CoH/B lZX1aMSj6cdU24/cb+rc+t2r0mb/dsWob8rXqRfsXG+CZ/wyZ/f9yLbGD4MSEP7r pYmHGM4N7jw2T9Ra4WPaz98SGD3IdPqrxVAeU2dD/cR8wGNdQPh1bb4aXFifeU3u KJa3jS8f/BGkbbM=
In-reply-to: <4E80D794.3040701@cavium.com>
References: <1316999280-11999-1-git-send-email-rongqing.li@windriver.com> <4E80D794.3040701@cavium.com>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mutt/1.5.21 (2010-09-15)
On Mon, Sep 26, 2011 at 12:50:44PM -0700, David Daney wrote:
> On 09/25/2011 06:08 PM, rongqing.li@windriver.com wrote:
> >From: Roy.Li<rongqing.li@windriver.com>
> >
> >Icmp packets with wrong checksum are never dropped since
> >skb->ip_summed is set to CHECKSUM_UNNECESSARY.
> >
> >When icmp packets with wrong checksum pass through the octeon
> >net driver, the not_IP, IP_exc, L4_error hardware indicators
> >show no error. so the driver sets CHECKSUM_UNNECESSARY on
> >skb->ip_summed.
> >
> >L4_error only works for TCP/UDP, not for ICMP.
> >
> >Signed-off-by: Roy.Li<rongqing.li@windriver.com>
> 
> We found the same problem, but have not yet sent the patch to fix it.
> 
> This looks fine to me,
> 
> Acked-by: David Daney <david.daney@cavium.com>
> 
> I would let davem, Ralf and Greg KH fight over who gets to merge it.

I'll let Ralf take it, unless he wants me to.

Ralf?


<Prev in Thread] Current Thread [Next in Thread>