linux-mips
[Top] [All Lists]

Re: [PATCH 2/5] MIPS: bcm63xx: fix SDRAM size computation for BCM6345

To: Sergei Shtylyov <sshtylyov@mvista.com>
Subject: Re: [PATCH 2/5] MIPS: bcm63xx: fix SDRAM size computation for BCM6345
From: Florian Fainelli <florian@openwrt.org>
Date: Thu, 22 Sep 2011 18:48:22 +0200
Cc: ralf@linux-mips.org, linux-mips@linux-mips.org
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=sender:from:organization:to:subject:date:user-agent:cc:references :in-reply-to:mime-version:content-type:content-transfer-encoding :message-id; bh=kRT2VbomZYhDGmXUmDPtJ8zEFrZpQ1Do/Qyh6+nINpc=; b=mLrbDg4JPBIIgPqY/y1U9H6LnAH0JZ9mJXi2GUosqa/64WonXSBBgsZFtRxZYJ8PrS rBq7CbjEhwcCHSYeWiuoMI53ENUYKFwbzwwmwg+vc9w/JRXhVwCof470OZxS5E6t2PSn ImDo9H7UOK2nGogC2faT0N2MRXsCgs7xuMOV8=
In-reply-to: <4E7B0C02.7060703@mvista.com>
Organization: OpenWrt
References: <1316612390-6367-1-git-send-email-florian@openwrt.org> <1316612390-6367-3-git-send-email-florian@openwrt.org> <4E7B0C02.7060703@mvista.com>
Sender: linux-mips-bounce@linux-mips.org
User-agent: KMail/1.13.6 (Linux/2.6.38-11-server; KDE/4.6.2; x86_64; ; )
On Thursday 22 September 2011 12:20:50 Sergei Shtylyov wrote:
> Hello.
> 
> On 21-09-2011 17:39, Florian Fainelli wrote:
> > From: Florian Fainelli<ffainelli@freebox.fr>
> > 
> > Instead of hardcoding the amount of available RAM, read the number of
> > effective multiples of 8MB from SDRAM_MBASE_REG.
> > 
> > Signed-off-by: Florian Fainelli<florian@openwrt.org>
> > ---
> > 
> >   arch/mips/bcm63xx/cpu.c |    6 ++++--
> >   1 files changed, 4 insertions(+), 2 deletions(-)
> > 
> > diff --git a/arch/mips/bcm63xx/cpu.c b/arch/mips/bcm63xx/cpu.c
> > index 7c7e4d4..7ad1b39 100644
> > --- a/arch/mips/bcm63xx/cpu.c
> > +++ b/arch/mips/bcm63xx/cpu.c
> > @@ -260,8 +260,10 @@ static unsigned int detect_memory_size(void)
> > 
> >     unsigned int cols = 0, rows = 0, is_32bits = 0, banks = 0;
> >     u32 val;
> > 
> > -   if (BCMCPU_IS_6345())
> > -           return (8 * 1024 * 1024);
> > +   if (BCMCPU_IS_6345()) {
> > +           val = bcm_sdram_readl(SDRAM_MBASE_REG);
> > +           return (val * 8 * 1024 * 1024);
> 
>     Parens not needed here.

For consistency with other parts of the code, I would rather keep it.
-- 
Florian

<Prev in Thread] Current Thread [Next in Thread>