| To: | jpirko@redhat.com |
|---|---|
| Subject: | Re: [patch net-next-2.6] net: consolidate and fix ethtool_ops->get_settings calling |
| From: | David Miller <davem@redhat.com> |
| Date: | Thu, 15 Sep 2011 17:33:39 -0400 (EDT) |
| Cc: | netdev@vger.kernel.org, ralf@linux-mips.org, fubar@us.ibm.com, andy@greyhouse.net, kaber@trash.net, bprakash@broadcom.com, JBottomley@parallels.com, robert.w.love@intel.com, shemminger@linux-foundation.org, decot@google.com, bhutchings@solarflare.com, mirq-linux@rere.qmqm.pl, alexander.h.duyck@intel.com, amit.salecha@qlogic.com, eric.dumazet@gmail.com, therbert@google.com, paulmck@linux.vnet.ibm.com, laijs@cn.fujitsu.com, xiaosuo@gmail.com, greearb@candelatech.com, loke.chetan@gmail.com, linux-mips@linux-mips.org, linux-scsi@vger.kernel.org, devel@open-fcoe.org, bridge@lists.linux-foundation.org |
| In-reply-to: | <1314905304-16485-1-git-send-email-jpirko@redhat.com> |
| References: | <1314905304-16485-1-git-send-email-jpirko@redhat.com> |
| Sender: | linux-mips-bounce@linux-mips.org |
From: Jiri Pirko <jpirko@redhat.com> Date: Thu, 1 Sep 2011 21:28:24 +0200 > This patch does several things: > - introduces __ethtool_get_settings which is called from ethtool code and > from dev_ethtool_get_settings() as well. > - dev_ethtool_get_settings() becomes rtnl wrapper for > __ethtool_get_settings() > - changes calling in drivers so rtnl locking is respected. In > iboe_get_rate was previously ->get_settings() called unlocked. This > fixes it > - introduces rtnl_lock in bnx2fc_vport_create() and fcoe_vport_create() > so bnx2fc_if_create() and fcoe_if_create() are called locked as they > are from other places. > - prb_calc_retire_blk_tmo() in af_packet.c was not calling get_settings > with rtnl_lock. So use dev_ethtool_get_settings here. > - use __ethtool_get_settings() in bonding code > > Signed-off-by: Jiri Pirko <jpirko@redhat.com> Applied, thanks. |
| Previous by Date: | Re: [PATCH] MIPS: SMTC: Correct saving of CP0_STATUS, Ralf Baechle |
|---|---|
| Next by Date: | [PATCH] MIPS: No branches in delay slots for huge pages in handle_tlbl, David Daney |
| Previous by Thread: | Re: [patch net-next-2.6 v3] net: consolidate and fix ethtool_ops->get_settings calling, Ralf Baechle |
| Next by Thread: | Re: [PATCH] I2C: SiByte: Convert the driver to make use of interrupts, Jean Delvare |
| Indexes: | [Date] [Thread] [Top] [All Lists] |