linux-mips
[Top] [All Lists]

Re: [PATCH 2/3] netdev/of/phy: Add MDIO bus multiplexer support.

To: Grant Likely <grant.likely@secretlab.ca>
Subject: Re: [PATCH 2/3] netdev/of/phy: Add MDIO bus multiplexer support.
From: David Daney <david.s.daney@gmail.com>
Date: Wed, 14 Sep 2011 21:16:10 -0700
Cc: David Daney <david.daney@cavium.com>, David Daney <ddaney@caviumnetworks.com>, linux-mips@linux-mips.org, linux-kernel@vger.kernel.org, "David S. Miller" <davem@davemloft.net>, netdev@vger.kernel.org, devicetree-discuss@lists.ozlabs.org, ralf@linux-mips.org
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:content-type:content-transfer-encoding; bh=xRgenVzK32h1nsbjcOU2elNyb7NaXr7GjZKuIePRNzM=; b=e3Jq5amCTqQ6LGrzzjC+fCT/pezv6II91fLD+mMYJqjq04LEroUj1dLs1kmoZp1Bqt v4orBVm5Wa11NydBEvi8LVhrx/gsThnGYHBdNgcYYjBMtJiP5mr99lSpUNDWwzWS8V5L GYSA4g+XSzQ1Rm1y7kAHZsqtUXOx7L3F2eCcU=
In-reply-to: <CACxGe6tA6D9JVf0_K-JAGnKcQmDmD=1ytqqYb6or-KjP9uZNxg@mail.gmail.com>
References: <1314820906-14004-1-git-send-email-david.daney@cavium.com> <1314820906-14004-3-git-send-email-david.daney@cavium.com> <CACxGe6tA6D9JVf0_K-JAGnKcQmDmD=1ytqqYb6or-KjP9uZNxg@mail.gmail.com>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.17) Gecko/20110428 Fedora/3.1.10-1.fc13 Thunderbird/3.1.10
On 09/14/2011 05:51 PM, Grant Likely wrote:


On Aug 31, 2011 2:01 PM, "David Daney" <david.daney@cavium.com <mailto:david.daney@cavium.com>> wrote:
>
> This patch adds a somewhat generic framework for MDIO bus
> multiplexers.  It is modeled on the I2C multiplexer.
>

[...]

> --- /dev/null
> +++ b/Documentation/devicetree/bindings/net/mdio-mux.txt
> @@ -0,0 +1,132 @@
> +Common MDIO bus multiplexer/switch properties.
> +
> +An MDIO bus multiplexer/switch will have several child busses that are
> +numbered uniquely in a device dependent manner.  The nodes for an MDIO
> +bus multiplexer/switch will have one child node for each child bus.
> +
> +Required properties:
> +- parent-bus : phandle to the parent MDIO bus.

As discussed, I like mdio-parent-bus.

> +
> +Optional properties:
> +- Other properties specific to the multiplexer/switch hardware.
> +
> +Required properties for child nodes:
> +- #address-cells = <1>;
> +- #size-cells = <0>;
> +- cell-index : The sub-bus number.

Use reg, not cell-index. That is what it is there for. And add the appropriate #address/size-cells in the parent.

I've not reviewed the implementation, but with the changes. I'm okay with the binding.


Thanks for the prompt reply Grant.

I will rework this with the binding changes and send a new version soon.

David Daney

<Prev in Thread] Current Thread [Next in Thread>