linux-mips
[Top] [All Lists]

Re: [PATCH] Impact video driver for SGI Indigo2

To: Sergei Shtylyov <sshtylyov@mvista.com>
Subject: Re: [PATCH] Impact video driver for SGI Indigo2
From: peter fuerst <post@pfrst.de>
Date: Tue, 13 Sep 2011 15:03:20 +0200 (CEST)
Cc: linux-mips@linux-mips.org
In-reply-to: <4E6F32AE.3040007@mvista.com>
References: <Pine.LNX.4.64.1109131101530.4143@Indigo2.Peter> <4E6F32AE.3040007@mvista.com>
Reply-to: post@pfrst.de
Sender: linux-mips-bounce@linux-mips.org


Hi Sergei,

On Tue, 13 Sep 2011, Sergei Shtylyov wrote:

Date: Tue, 13 Sep 2011 14:38:38 +0400
From: Sergei Shtylyov <sshtylyov@mvista.com>
To: post@pfrst.de
Cc: linux-mips@linux-mips.org
Subject: Re: [PATCH] Impact video driver for SGI Indigo2

Hello.

...
There are alos empty lines after each file in the patch -- which
shouldn't be there.

These were intended for readability (reviewability :), but i can remove
them easily (of course).

  These will prevent the patch from applying, AFAIK.


i do a "patch -p1<diffile; git add ..." and patch just discards (as
expected) any "comment"-lines before, between and after the chunks.

...


WBR, Sergei



kind regards

peter

<Prev in Thread] Current Thread [Next in Thread>