linux-mips
[Top] [All Lists]

Re: [PATCH] MIPS: SMTC: Correct saving of CP0_STATUS

To: David Daney <david.daney@cavium.com>
Subject: Re: [PATCH] MIPS: SMTC: Correct saving of CP0_STATUS
From: "Edgar E. Iglesias" <edgar.iglesias@gmail.com>
Date: Tue, 30 Aug 2011 07:57:09 +0200
Cc: linux-mips@linux-mips.org, Ralf Baechle <ralf@linux-mips.org>
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; bh=C8+kqIjJnngXsz9wb5vtEdAg+LlgV5I05F0CALmz+y4=; b=QWYH6XSYimJn7dzLNKMiRwc1uiHozbCYMWjIReFuqbpsS98YsOhEFTWh676A4lMlbn LoQRbkI5Fn094q0ywqKoj9/fAllieBJ/u6XZV9mPyc4PqKwlEGsohnPC3H0DDvZUUoay Ki79VDy5u6X82zgFQJqqpuxYnz3ALvwe9i0YE=
In-reply-to: <4E5C2490.6040203@cavium.com>
References: <20110829232029.GA15763@zapo> <4E5C2490.6040203@cavium.com>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mutt/1.5.21 (2010-09-15)
On Mon, Aug 29, 2011 at 04:45:20PM -0700, David Daney wrote:
> On 08/29/2011 04:20 PM, Edgar E. Iglesias wrote:
> >Hi,
> >
> >Commit 362e696428590f7d0a5d0971a2d04b0372a761b8
> >reorders a bunch of insns to improve the flow of the pipeline but
> >for MT_SMTC kernels, AFAICT, the saving of CP0_STATUS seems wrong.
> 
> Indeed.
> 
> >
> >Am I missing something?
> >
> 
> It does look like in the MIPS_MT_SMTC case we are clobbering the
> value in v1.
> 
> >If not here is a patch, tested with qemu.
> >
> 
> How about the attached completely untested one instead?
> 
> David Daney

> From d0035295ae34bcf84d601b1e25e2642fe0802752 Mon Sep 17 00:00:00 2001
> From: David Daney <david.daney@cavium.com>
> Date: Mon, 29 Aug 2011 16:42:12 -0700
> Subject: [PATCH] MIPS: Don't clobber CP0_STATUS vaue for CONFIG_MIPS_MT_SMTC
> 
> Untested, but it looks nice.


Thanks, I like you patch better. But whichever version will do.

Cheers

<Prev in Thread] Current Thread [Next in Thread>