Re: [PATCH] MIPS: SMTC: Correct saving of CP0_STATUS

[David Daney <david.daney@cavium.com>]

On 08/29/2011 04:55 PM, Kevin D. Kissell wrote:
> I submitted that exact patch (David's more minimal version) in December
> 2010 (and I did test it).  Did it not take?
Evidently not.  Perhaps Ralf will see fit to commit it this time.

>  See the thread "SMTC
> support status in latest git head".  The patch went out on December 24
> (why I was spending my Christmas Eve fixing MIPS Linux is another
> question... :op )
... one which I will not attempt to address.

David Daney.


>              Kevin K.
>
> On 08/29/11 16:45, David Daney wrote:
> > On 08/29/2011 04:20 PM, Edgar E. Iglesias wrote:
> > > Hi,
> > >
> > > Commit 362e696428590f7d0a5d0971a2d04b0372a761b8
> > > reorders a bunch of insns to improve the flow of the pipeline but
> > > for MT_SMTC kernels, AFAICT, the saving of CP0_STATUS seems wrong.
> > Indeed.
> >
> > > Am I missing something?
> > It does look like in the MIPS_MT_SMTC case we are clobbering the value
> > in v1.
> >
> > > If not here is a patch, tested with qemu.
> > How about the attached completely untested one instead?
> >
> > David Daney