linux-mips
[Top] [All Lists]

Re: [PATCH] MIPS: SMTC: Correct saving of CP0_STATUS

To: "Kevin D. Kissell" <kevink@paralogos.com>, Ralf Baechle <ralf@linux-mips.org>
Subject: Re: [PATCH] MIPS: SMTC: Correct saving of CP0_STATUS
From: David Daney <david.daney@cavium.com>
Date: Mon, 29 Aug 2011 17:14:26 -0700
Cc: "Edgar E. Iglesias" <edgar.iglesias@gmail.com>, linux-mips@linux-mips.org
In-reply-to: <4E5C26D4.3000906@paralogos.com>
References: <20110829232029.GA15763@zapo> <4E5C2490.6040203@cavium.com> <4E5C26D4.3000906@paralogos.com>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.15) Gecko/20101027 Fedora/3.0.10-1.fc12 Thunderbird/3.0.10
On 08/29/2011 04:55 PM, Kevin D. Kissell wrote:
I submitted that exact patch (David's more minimal version) in December
2010 (and I did test it).  Did it not take?

Evidently not.  Perhaps Ralf will see fit to commit it this time.

 See the thread "SMTC
support status in latest git head".  The patch went out on December 24
(why I was spending my Christmas Eve fixing MIPS Linux is another
question... :op )


... one which I will not attempt to address.

David Daney.


             Kevin K.

On 08/29/11 16:45, David Daney wrote:
On 08/29/2011 04:20 PM, Edgar E. Iglesias wrote:
Hi,

Commit 362e696428590f7d0a5d0971a2d04b0372a761b8
reorders a bunch of insns to improve the flow of the pipeline but
for MT_SMTC kernels, AFAICT, the saving of CP0_STATUS seems wrong.

Indeed.


Am I missing something?


It does look like in the MIPS_MT_SMTC case we are clobbering the value
in v1.

If not here is a patch, tested with qemu.


How about the attached completely untested one instead?

David Daney




<Prev in Thread] Current Thread [Next in Thread>