linux-mips
[Top] [All Lists]

Re: [PATCH] MIPS: SMTC: Correct saving of CP0_STATUS

To: David Daney <david.daney@cavium.com>
Subject: Re: [PATCH] MIPS: SMTC: Correct saving of CP0_STATUS
From: "Kevin D. Kissell" <kevink@paralogos.com>
Date: Mon, 29 Aug 2011 16:55:00 -0700
Cc: "Edgar E. Iglesias" <edgar.iglesias@gmail.com>, linux-mips@linux-mips.org, Ralf Baechle <ralf@linux-mips.org>
Domainkey-signature: a=rsa-sha1; q=dns; c=nofws; s=default; d=paralogos.com; h=Received:Message-ID:Date:From:User-Agent:MIME-Version:To:CC:Subject:References:In-Reply-To:X-Enigmail-Version:Content-Type:Content-Transfer-Encoding:X-BWhitelist:X-Source:X-Source-Args:X-Source-Dir:X-Source-Sender:X-Source-Auth:X-Email-Count:X-Source-Cap; b=HwJKOTdh6/SNmN9quYpmhXgcfBFpzci0X1q240yDgnXGvm3vhezO2bfGdMD5jFFnmYM4/ZkBPauVHAnJGvGhrnCzSdmxU2wKyCJcy9/hAhBbFLeXw18VjipEdy1SMj1d;
In-reply-to: <4E5C2490.6040203@cavium.com>
References: <20110829232029.GA15763@zapo> <4E5C2490.6040203@cavium.com>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.18) Gecko/20110617 Thunderbird/3.1.11
I submitted that exact patch (David's more minimal version) in December
2010 (and I did test it).  Did it not take?  See the thread "SMTC
support status in latest git head".  The patch went out on December 24
(why I was spending my Christmas Eve fixing MIPS Linux is another
question... :op )

            Kevin K.

On 08/29/11 16:45, David Daney wrote:
> On 08/29/2011 04:20 PM, Edgar E. Iglesias wrote:
>> Hi,
>>
>> Commit 362e696428590f7d0a5d0971a2d04b0372a761b8
>> reorders a bunch of insns to improve the flow of the pipeline but
>> for MT_SMTC kernels, AFAICT, the saving of CP0_STATUS seems wrong.
>
> Indeed.
>
>>
>> Am I missing something?
>>
>
> It does look like in the MIPS_MT_SMTC case we are clobbering the value
> in v1.
>
>> If not here is a patch, tested with qemu.
>>
>
> How about the attached completely untested one instead?
>
> David Daney


<Prev in Thread] Current Thread [Next in Thread>