linux-mips
[Top] [All Lists]

Re: [PATCH] MIPS: SMTC: Correct saving of CP0_STATUS

To: "Edgar E. Iglesias" <edgar.iglesias@gmail.com>
Subject: Re: [PATCH] MIPS: SMTC: Correct saving of CP0_STATUS
From: David Daney <david.daney@cavium.com>
Date: Mon, 29 Aug 2011 16:45:20 -0700
Cc: linux-mips@linux-mips.org, Ralf Baechle <ralf@linux-mips.org>
In-reply-to: <20110829232029.GA15763@zapo>
References: <20110829232029.GA15763@zapo>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.15) Gecko/20101027 Fedora/3.0.10-1.fc12 Thunderbird/3.0.10
On 08/29/2011 04:20 PM, Edgar E. Iglesias wrote:
Hi,

Commit 362e696428590f7d0a5d0971a2d04b0372a761b8
reorders a bunch of insns to improve the flow of the pipeline but
for MT_SMTC kernels, AFAICT, the saving of CP0_STATUS seems wrong.

Indeed.


Am I missing something?


It does look like in the MIPS_MT_SMTC case we are clobbering the value in v1.

If not here is a patch, tested with qemu.


How about the attached completely untested one instead?

David Daney

Attachment: 0001-MIPS-Don-t-clobber-CP0_STATUS-vaue-for-CONFIG_MIPS_M.patch
Description: Text document

<Prev in Thread] Current Thread [Next in Thread>