linux-mips
[Top] [All Lists]

Re: [PATCH v3 0/2] Pass resources to pci_create_bus() and fix MIPS PCI r

To: Deng-Cheng Zhu <dczhu@mips.com>
Subject: Re: [PATCH v3 0/2] Pass resources to pci_create_bus() and fix MIPS PCI resources
From: Bjorn Helgaas <bhelgaas@google.com>
Date: Fri, 26 Aug 2011 07:54:00 -0600
Cc: jbarnes@virtuousgeek.org, ralf@linux-mips.org, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mips@linux-mips.org, eyal@mips.com, zenon@mips.com, dengcheng.zhu@gmail.com
Dkim-signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=google.com; s=beta; t=1314366862; bh=IJUZAMijF09miexognkruib5sYM=; h=MIME-Version:In-Reply-To:References:From:Date:Message-ID:Subject: To:Cc:Content-Type:Content-Transfer-Encoding; b=gIp6A1CBAMDDI4vLhEQQptjkFX3bUfRYR/xqfzapoN4L9a0t4PM1vqQen85JmegB9 oy7U8Y0JdgLdmICOJZjXw==
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=beta; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type:content-transfer-encoding; bh=0jj/350DOUoTSu2VscFTgfALSNpVgwzm8MEBKxp6tNY=; b=U5u3frhd1UlgzOhmceugi6iRyQ/zNfWNQyTLb24ir90XNW1ARfmyEbE09rrccembcI WsULfsay8pq1AW2MP2Aw==
Domainkey-signature: a=rsa-sha1; s=beta; d=google.com; c=nofws; q=dns; h=dkim-signature:mime-version:in-reply-to:references:from:date: message-id:subject:to:cc:content-type: content-transfer-encoding:x-system-of-record; b=vo1631kIGQ+XShmZQI5ra1lGhZjK+fvuB5XS7AgHqcRt/7END8r/8sq0iRRQdAIvi 3AB/C30QyCOjg55m+9hZQ==
In-reply-to: <1314349633-13155-1-git-send-email-dczhu@mips.com>
References: <1314349633-13155-1-git-send-email-dczhu@mips.com>
Sender: linux-mips-bounce@linux-mips.org
On Fri, Aug 26, 2011 at 3:07 AM, Deng-Cheng Zhu <dczhu@mips.com> wrote:
> Change the pci_create_bus() interface to pass in available resources to get 
> them
> settled down early. This is to avoid possible resource conflicts while doing
> pci_scan_slot() in pci_scan_child_bus(). Note that pcibios_fixup_bus() can get
> rid of such conflicts, but it's done AFTER scanning slots.
>
> In addition, MIPS PCI resources are now fixed using this new interface.
>
> -- Changes --
> v3 - v2:
> o Do not do fixups for root buses in pcibios_fixup_bus().
> o Skip bus creation when bus resources cannot be allocated.
> o PCI domain/bus numbers added to the error info in controller_resources().
>
> v2 - v1:
> o Merge [PATCH 1/3] to [PATCH 3/3], so now 2 patches in total.
> o Add more info to patch description.
> o Fix arch breaks in default resource setup discovered by Bjorn Helgaas.
>
> Deng-Cheng Zhu (2):
>  PCI: Pass available resources into pci_create_bus()
>  MIPS: PCI: Pass controller's resources to pci_create_bus() in
>    pcibios_scanbus()
>
>  arch/microblaze/pci/pci-common.c |    3 +-
>  arch/mips/pci/pci.c              |   61 
> +++++++++++++++++++++++++++++++++-----
>  arch/powerpc/kernel/pci-common.c |    3 +-
>  arch/sparc/kernel/pci.c          |    3 +-
>  arch/x86/pci/acpi.c              |    2 +-
>  drivers/pci/probe.c              |   15 +++++++--
>  include/linux/pci.h              |    3 +-
>  7 files changed, 73 insertions(+), 17 deletions(-)

This is beautiful.  Thanks for doing this work!  I hope other
architectures will follow your lead and get rid of their root bus
resource fixups.

Reviewed-by: Bjorn Helgaas <bhelgaas@google.com>

<Prev in Thread] Current Thread [Next in Thread>