linux-mips
[Top] [All Lists]

Re: [RFC PATCH 1/3] MIPS: PCI: Use pci_bus_remove_resources()/pci_bus_ad

To: Deng-Cheng Zhu <dengcheng.zhu@gmail.com>
Subject: Re: [RFC PATCH 1/3] MIPS: PCI: Use pci_bus_remove_resources()/pci_bus_add_resource() to set up root resources
From: Bjorn Helgaas <bhelgaas@google.com>
Date: Thu, 25 Aug 2011 09:34:43 -0600
Cc: jbarnes@virtuousgeek.org, ralf@linux-mips.org, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mips@linux-mips.org, eyal@mips.com, zenon@mips.com
Dkim-signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=google.com; s=beta; t=1314286505; bh=zxt2OvbAOt5V6xPGA6PHbTiKC88=; h=MIME-Version:In-Reply-To:References:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=SkY057VPfFrIipg6RXMb/l1siQ4TNwWMQYf6eOLoUtHJlbPQWigoP1zZKDdfccIJ+ nj18bHIOWhlFdNQTj0uEw==
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=beta; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type; bh=f958P2JMPIcdOJBqN6mtOuTHATzj6DPYppkat5Dk5uY=; b=OUtIfNPus6rHH4FOYiNg0IRxAb48HlQuxHjGj7P05TBJ9u5d4/k7UbNt54e1yoDwnD idvusPVR4Aji52gFJuxA==
Domainkey-signature: a=rsa-sha1; s=beta; d=google.com; c=nofws; q=dns; h=dkim-signature:mime-version:in-reply-to:references:from:date: message-id:subject:to:cc:content-type:x-system-of-record; b=vP86hFcIutjfhTxkJLXi21/bL8WoCLHjmn11KCq+NS29GuN1mrnnlY61GKP0xL6y9 pmaQhLidx80KaJ8pOXXHg==
In-reply-to: <CAOfQC98Nkr7Ek3uQfiD3OdW=YC76XGjfQ4WSfoLpsm2kvqKnog@mail.gmail.com>
References: <1314167063-15785-1-git-send-email-dengcheng.zhu@gmail.com> <1314167063-15785-2-git-send-email-dengcheng.zhu@gmail.com> <CAErSpo4091J2pGvzZKPbKK68LWWkDyVApA7suZYn7miq=tXrQg@mail.gmail.com> <CAOfQC98Nkr7Ek3uQfiD3OdW=YC76XGjfQ4WSfoLpsm2kvqKnog@mail.gmail.com>
Sender: linux-mips-bounce@linux-mips.org
On Thu, Aug 25, 2011 at 12:41 AM, Deng-Cheng Zhu
<dengcheng.zhu@gmail.com> wrote:
> 2011/8/24 Bjorn Helgaas <bhelgaas@google.com>:
>> Wouldn't it be enough to have [PATCH 2/3], which adds the
>> pci_create_bus() argument with nobody using it yet, then [PATCH 3/3],
>> which makes mips supply the new argument, and add a hunk to [PATCH
>> 3/3] that completely removes the bus->resource fixups in
>> pcibios_fixup_bus() at the same time?
>>
>> Bjorn
>>
>
> Do you mean to merge this patch to [PATCH 3/3]? OK, that's good!

No, I just mean that I don't see why you need this patch at all.  If
you pass the list of bus resources to pci_create_bus(), there's no
need to fix anything up later.  Or am I missing something?

Bjorn

<Prev in Thread] Current Thread [Next in Thread>