linux-mips
[Top] [All Lists]

[RFC PATCH 1/3] MIPS: PCI: Use pci_bus_remove_resources()/pci_bus_add_re

To: jbarnes@virtuousgeek.org, ralf@linux-mips.org
Subject: [RFC PATCH 1/3] MIPS: PCI: Use pci_bus_remove_resources()/pci_bus_add_resource() to set up root resources
From: Deng-Cheng Zhu <dengcheng.zhu@gmail.com>
Date: Wed, 24 Aug 2011 14:24:21 +0800
Cc: linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mips@linux-mips.org, eyal@mips.com, zenon@mips.com, dengcheng.zhu@gmail.com
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=from:to:cc:subject:date:message-id:x-mailer:in-reply-to:references; bh=oQhGMEtV4oStccPP9ahvbwq6IrsL3qxwSAd2dDHURjc=; b=yBg4wEgh25u++1IdHJY8ud12ictw3CDCkeMFiIeuIFr7qsAmt3+ynxUlM+vae5SGi8 VjZVAbCY5DnBww2Wjb6/WRW4sZOudzoeg/bB9seTTLzLJeNbJm3BnHSHgDFjRH5usVrr VFYkO+lAvci4Hx0Y5/J09gYajermEW4n+7G1Q=
In-reply-to: <1314167063-15785-1-git-send-email-dengcheng.zhu@gmail.com>
References: <1314167063-15785-1-git-send-email-dengcheng.zhu@gmail.com>
Sender: linux-mips-bounce@linux-mips.org
Use this new style (instead of filling in the pci_bus->resource[] array
directly) to hide some ugly implementation details.

Signed-off-by: Deng-Cheng Zhu <dengcheng.zhu@gmail.com>
---
 arch/mips/pci/pci.c |   11 +++++++++--
 1 files changed, 9 insertions(+), 2 deletions(-)

diff --git a/arch/mips/pci/pci.c b/arch/mips/pci/pci.c
index 33bba7b..7473214 100644
--- a/arch/mips/pci/pci.c
+++ b/arch/mips/pci/pci.c
@@ -261,6 +261,14 @@ static void pcibios_fixup_device_resources(struct pci_dev 
*dev,
        }
 }
 
+static void __devinit
+pcibios_setup_root_resources(struct pci_bus *bus, struct pci_controller *ctrl)
+{
+       pci_bus_remove_resources(bus);
+       pci_bus_add_resource(bus, ctrl->io_resource, 0);
+       pci_bus_add_resource(bus, ctrl->mem_resource, 0);
+}
+
 void __devinit pcibios_fixup_bus(struct pci_bus *bus)
 {
        /* Propagate hose info into the subordinate devices.  */
@@ -270,8 +278,7 @@ void __devinit pcibios_fixup_bus(struct pci_bus *bus)
        struct pci_dev *dev = bus->self;
 
        if (!dev) {
-               bus->resource[0] = hose->io_resource;
-               bus->resource[1] = hose->mem_resource;
+               pcibios_setup_root_resources(bus, hose);
        } else if (pci_probe_only &&
                   (dev->class >> 8) == PCI_CLASS_BRIDGE_PCI) {
                pci_read_bridge_bases(bus);
-- 
1.7.1


<Prev in Thread] Current Thread [Next in Thread>