linux-mips
[Top] [All Lists]

Re: [PATCH] I2C: SiByte: Convert the driver to make use of interrupts

To: Matt Turner <mattst88@gmail.com>
Subject: Re: [PATCH] I2C: SiByte: Convert the driver to make use of interrupts
From: Guenter Roeck <guenter.roeck@ericsson.com>
Date: Mon, 22 Aug 2011 13:02:56 -0700
Cc: Jean Delvare <khali@linux-fr.org>, "linux-i2c@vger.kernel.org" <linux-i2c@vger.kernel.org>, "linux-mips@linux-mips.org" <linux-mips@linux-mips.org>, Ralf Baechle <ralf@linux-mips.org>, "Maciej W. Rozycki" <macro@linux-mips.org>
In-reply-to: <1313710991-3596-1-git-send-email-mattst88@gmail.com>
Organization: Ericsson
References: <1313710991-3596-1-git-send-email-mattst88@gmail.com>
Reply-to: guenter.roeck@ericsson.com
Sender: linux-mips-bounce@linux-mips.org
On Thu, 2011-08-18 at 19:43 -0400, Matt Turner wrote:
> From: Maciej W. Rozycki <macro@linux-mips.org>
> 
> This is a rewrite of large parts of the driver mainly so that it uses
> SMBus interrupts to offload the CPU from busy-waiting on status inputs.
> As a part of the overhaul of the init and exit calls, all accesses to the
> hardware got converted to use accessory functions via an ioremap() cookie.
> 
> [mattst88] Added BCM1480 interrupts and rebased minimally.
> 
> Signed-off-by: Matt Turner <mattst88@gmail.com>
> Signed-off-by: Maciej W. Rozycki <macro@linux-mips.org>

Patch works fine on our target, and shows significant speed improvements
for i2c accesses.

Linux version 3.0.3-428-g17c1f3f (groeck@rbos-pc-13) (gcc version 4.4.1
(Debian 4.4.1-1) ) #2 SMP Mon Aug 22 12:56:41 PDT 2011
bootconsole [early0] enabled
CPU revision is: 01041100 (SiByte SB1A)
FPU revision is: 000f0103
Checking for the multiply/shift bug... no.
Checking for the daddiu bug... no.
Broadcom SiByte BCM1480 B1 (pass2) @ 900 MHz (SB-1A rev 0)

Tested-by: Guenter Roeck <guenter.roeck@ericsson.com>

Guenter



<Prev in Thread] Current Thread [Next in Thread>