linux-mips
[Top] [All Lists]

Re: [PATCH 02/11] arch/mips: do not use EXTRA_CFLAGS

To: Arnaud Lacombe <lacombar@gmail.com>
Subject: Re: [PATCH 02/11] arch/mips: do not use EXTRA_CFLAGS
From: Sergei Shtylyov <sshtylyov@mvista.com>
Date: Mon, 15 Aug 2011 13:45:04 +0400
Cc: linux-kernel@vger.kernel.org, Sam Ravnborg <sam@ravnborg.org>, linux-mips@linux-mips.org
In-reply-to: <1313384834-24433-3-git-send-email-lacombar@gmail.com>
References: <1313384834-24433-1-git-send-email-lacombar@gmail.com> <1313384834-24433-3-git-send-email-lacombar@gmail.com>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mozilla/5.0 (Windows NT 5.1; rv:5.0) Gecko/20110624 Thunderbird/5.0
Hello.

On 15-08-2011 9:07, Arnaud Lacombe wrote:

Usage of these flags has been deprecated for nearly 4 years by:

     commit f77bf01425b11947eeb3b5b54685212c302741b8
     Author: Sam Ravnborg<sam@neptun.(none)>
     Date:   Mon Oct 15 22:25:06 2007 +0200

         kbuild: introduce ccflags-y, asflags-y and ldflags-y

Moreover, these flags (at least EXTRA_CFLAGS) have been documented for command
line use. By default, gmake(1) do not override command line setting, so this is
likely to result in build failure or unexpected behavior.

Replace their usage by Kbuild's `{as,cc,ld}flags-y'.

Cc: Sam Ravnborg<sam@ravnborg.org>
Cc: linux-mips@linux-mips.org

   You didn't sign off.

WBR, Sergei

<Prev in Thread] Current Thread [Next in Thread>