Re: [PATCH V2 1/8] MIPS: Alchemy: abstract USB block control register access

[Manuel Lauss <manuel.lauss@googlemail.com>]

On Fri, Aug 12, 2011 at 8:42 PM, Greg KH <gregkh@suse.de> wrote:
> On Fri, Aug 12, 2011 at 08:12:33PM +0200, Manuel Lauss wrote:
>> Alchemy chips have one or more registers which control access
>> to the usb blocks as well as PHY configuration.  I don't want
>> the OHCI/EHCI glues to know about the different registers and bits;
>> new code hides the gory details of USB configuration from them.
>>
>> Cc: linux-usb@vger.kernel.org
>> Cc: Greg Kroah-Hartman <gregkh@suse.de>  (USB glue parts)
>> Signed-off-by: Manuel Lauss <manuel.lauss@googlemail.com>
>> ---
>> V2: moved the chip-specific parts from arch home to usb/host/alchemy-common.c
>>
>>  arch/mips/alchemy/common/dma.c             |   12 +-
>>  arch/mips/alchemy/common/power.c           |   42 ----
>>  arch/mips/include/asm/mach-au1x00/au1000.h |   84 ++------
>>  drivers/usb/host/Makefile                  |    1 +
>>  drivers/usb/host/alchemy-common.c          |  337 
>> ++++++++++++++++++++++++++++
>>  drivers/usb/host/ehci-au1xxx.c             |   77 +------
>>  drivers/usb/host/ohci-au1xxx.c             |  110 +--------
>>  7 files changed, 382 insertions(+), 281 deletions(-)
>>  create mode 100644 drivers/usb/host/alchemy-common.c
>
> Much nicer, thanks.
>
> I can take this in the USB tree if the MIPS developers want, or if not,
> feel free to add:
>        Acked-by: Greg Kroah-Hartman <gregkh@suse.de>
> and take it through the MIPS tree.

Great, thanks.  Other patches to the  MIPS tree depend on this one, so
I hope Ralf will take it.

Manuel