linux-mips
[Top] [All Lists]

Re: [PATCH V2 1/8] MIPS: Alchemy: abstract USB block control register ac

To: Manuel Lauss <manuel.lauss@googlemail.com>
Subject: Re: [PATCH V2 1/8] MIPS: Alchemy: abstract USB block control register access
From: Greg KH <gregkh@suse.de>
Date: Fri, 12 Aug 2011 11:42:27 -0700
Cc: Linux-MIPS <linux-mips@linux-mips.org>, Ralf Baechle <ralf@linux-mips.org>, linux-usb@vger.kernel.org
In-reply-to: <1313172753-31088-1-git-send-email-manuel.lauss@googlemail.com>
References: <1313172753-31088-1-git-send-email-manuel.lauss@googlemail.com>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mutt/1.5.21 (2010-09-15)
On Fri, Aug 12, 2011 at 08:12:33PM +0200, Manuel Lauss wrote:
> Alchemy chips have one or more registers which control access
> to the usb blocks as well as PHY configuration.  I don't want
> the OHCI/EHCI glues to know about the different registers and bits;
> new code hides the gory details of USB configuration from them.
> 
> Cc: linux-usb@vger.kernel.org
> Cc: Greg Kroah-Hartman <gregkh@suse.de>  (USB glue parts)
> Signed-off-by: Manuel Lauss <manuel.lauss@googlemail.com>
> ---
> V2: moved the chip-specific parts from arch home to usb/host/alchemy-common.c
> 
>  arch/mips/alchemy/common/dma.c             |   12 +-
>  arch/mips/alchemy/common/power.c           |   42 ----
>  arch/mips/include/asm/mach-au1x00/au1000.h |   84 ++------
>  drivers/usb/host/Makefile                  |    1 +
>  drivers/usb/host/alchemy-common.c          |  337 
> ++++++++++++++++++++++++++++
>  drivers/usb/host/ehci-au1xxx.c             |   77 +------
>  drivers/usb/host/ohci-au1xxx.c             |  110 +--------
>  7 files changed, 382 insertions(+), 281 deletions(-)
>  create mode 100644 drivers/usb/host/alchemy-common.c

Much nicer, thanks.

I can take this in the USB tree if the MIPS developers want, or if not,
feel free to add:
        Acked-by: Greg Kroah-Hartman <gregkh@suse.de>
and take it through the MIPS tree.

greg k-h

<Prev in Thread] Current Thread [Next in Thread>