linux-mips
[Top] [All Lists]

Re: [PATCH 1/8] MIPS: Alchemy: abstract USB block control register acces

To: Greg KH <gregkh@suse.de>
Subject: Re: [PATCH 1/8] MIPS: Alchemy: abstract USB block control register access
From: Manuel Lauss <manuel.lauss@googlemail.com>
Date: Fri, 12 Aug 2011 18:20:48 +0200
Cc: Linux-MIPS <linux-mips@linux-mips.org>, Ralf Baechle <ralf@linux-mips.org>, linux-usb@vger.kernel.org
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=gamma; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type:content-transfer-encoding; bh=sM9LQNH3ENom3o/OGrsoRWzsC2yBXdzkcWyAdAB6Irw=; b=sv8oKsAzuqM/eL+IWD1K/MIPGWd3S4Cq7QKD8Pp1jZ8zOxmIOuibGe4E9ufinJxr0C kzUN6TkpD/0XOIEzTxpquvm6w3r0xgylMV9IH8Rb5Bm9/KeHWQH66irjegndEvIxC7Je mweBV8awrV6tOXTTU1Ip6UnfRd/pdKcfr0NEI=
In-reply-to: <20110812160454.GA11898@suse.de>
References: <1313141985-5830-1-git-send-email-manuel.lauss@googlemail.com> <1313141985-5830-2-git-send-email-manuel.lauss@googlemail.com> <20110812160454.GA11898@suse.de>
Sender: linux-mips-bounce@linux-mips.org
On Fri, Aug 12, 2011 at 6:04 PM, Greg KH <gregkh@suse.de> wrote:
> On Fri, Aug 12, 2011 at 11:39:38AM +0200, Manuel Lauss wrote:
>> Alchemy chips have one or more registers which control access
>> to the usb blocks as well as PHY configuration.  I don't want
>> the OHCI/EHCI glues to know about the different registers and bits;
>> new arch code hides the gory details of USB configuration from them.
>>
>> Cc: linux-usb@vger.kernel.org
>> Cc: Greg Kroah-Hartman <gregkh@suse.de>  (USB glue parts)
>> Signed-off-by: Manuel Lauss <manuel.lauss@googlemail.com>
>> ---
>> CC'ed Greg for an Ack on the USB glue parts.  I'd like this to go through the
>>  MIPS tree since other changes in it depend on it.
>
> Fine with me on the USB portions, you are just deleting code, which I
> like :)

Thanks!


> But should the "common" USB code really live under arch/mips/alchemy/ ?
> The goal is to move driver code out of arch/ and into drivers/.  Why are
> you moving stuff backwards here?

This is just chip-dependent code for usb block and phy management, which
varies wich chip subtype, the OHCI and EHCI controllers are identical on all
of them.  At the time moving the chip-depedent code to the other chip-dependent
code seemed like a good idea...


Manuel

<Prev in Thread] Current Thread [Next in Thread>