linux-mips
[Top] [All Lists]

Re: [PATCH 19/23] mips: Use HAVE_MEMBLOCK_NODE_MAP

To: Ralf Baechle <ralf@linux-mips.org>
Subject: Re: [PATCH 19/23] mips: Use HAVE_MEMBLOCK_NODE_MAP
From: Tejun Heo <tj@kernel.org>
Date: Wed, 3 Aug 2011 18:26:18 +0200
Cc: benh@kernel.crashing.org, yinghai@kernel.org, hpa@zytor.com, tony.luck@intel.com, schwidefsky@de.ibm.com, liqin.chen@sunplusct.com, lethal@linux-sh.org, davem@davemloft.net, linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, mingo@redhat.com, linux-mips@linux-mips.org
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; bh=fsoA+NQzTZZAtORdLxO279vF5SsEUQHpaeUBumdPqo0=; b=tTtZ5ha+ojSEJpTDqj9sXm9vsU+te2/zf+Z7jNmhtn6g+6nOPYcDvI+QLrugIyGDaC 7O19d0iXe4i5+AweJ3DBYlY5PNGJR7PYym9rVZjUJrQNrD0TYbvL2c2H9QXHNkHF6CGp 5s6C+wA8iMHG42kmpNxTpZIN2U26fz4P7GqFI=
In-reply-to: <20110803161745.GA13266@linux-mips.org>
References: <1311694534-5161-1-git-send-email-tj@kernel.org> <1311694534-5161-20-git-send-email-tj@kernel.org> <20110803161745.GA13266@linux-mips.org>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mutt/1.5.21 (2010-09-15)
On Wed, Aug 03, 2011 at 05:17:45PM +0100, Ralf Baechle wrote:
> On Tue, Jul 26, 2011 at 05:35:30PM +0200, Tejun Heo wrote:
> 
> > mips used early_node_map[] just to prime free_area_init_nodes().  Now
> > memblock can be used for the same purpose and early_node_map[] is
> > scheduled to be dropped.  Use memblock instead.
> > 
> > Signed-off-by: Tejun Heo <tj@kernel.org>
> > Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
> > Cc: Yinghai Lu <yinghai@kernel.org>
> > Cc: Ralf Baechle <ralf@linux-mips.org>
> > Cc: linux-mips@linux-mips.org
> > ---
> > Only compile tested.  Thanks.
> > 
> >  arch/mips/Kconfig                |    3 +++
> >  arch/mips/kernel/setup.c         |    3 ++-
> >  arch/mips/sgi-ip27/ip27-memory.c |    5 +++--
> >  3 files changed, 8 insertions(+), 3 deletions(-)
> > 
> > diff --git a/arch/mips/Kconfig b/arch/mips/Kconfig
> > index 653da62..368b2ec 100644
> > --- a/arch/mips/Kconfig
> > +++ b/arch/mips/Kconfig
> > @@ -24,6 +24,9 @@ config MIPS
> >     select GENERIC_IRQ_PROBE
> >     select GENERIC_IRQ_SHOW
> >     select HAVE_ARCH_JUMP_LABEL
> > +   select HAVE_MEMBLOCK
> 
> This means <linux/memblock.h> will include <asm/memblock.h> which does
> not exist for MIPS.  Did you accidentally not post this new file?

Nope, earlier commit 24aa07882b and its fix patch (patch 0.5 in this
series) removes asm/memblock.h from all archs and drops it from
linux/memblock.h.

Thanks.

-- 
tejun

<Prev in Thread] Current Thread [Next in Thread>