linux-mips
[Top] [All Lists]

Re: [PATCH 2/7] MIPS: static should be at beginning of declaration

To: Jesper Juhl <jj@chaosbits.net>
Subject: Re: [PATCH 2/7] MIPS: static should be at beginning of declaration
From: Ralf Baechle <ralf@linux-mips.org>
Date: Tue, 2 Aug 2011 10:24:38 +0100
Cc: linux-kernel@vger.kernel.org, trivial@kernel.org, Lars-Peter Clausen <lars@metafoo.de>, linux-mips@linux-mips.org
In-reply-to: <alpine.LNX.2.00.1107092311190.25516@swampdragon.chaosbits.net>
References: <alpine.LNX.2.00.1107092304160.25516@swampdragon.chaosbits.net> <alpine.LNX.2.00.1107092311190.25516@swampdragon.chaosbits.net>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mutt/1.5.21 (2010-09-15)
On Sat, Jul 09, 2011 at 11:12:35PM +0200, Jesper Juhl wrote:

> Make sure that the 'static' keywork is at the beginning of declaration
> for arch/mips/include/asm/mach-jz4740/gpio.h
> 
> This gets rid of warnings like
>   warning: ‘static’ is not at beginning of declaration
> when building with -Wold-style-declaration (and/or -Wextra which also
> enables it).
> Also a few tiny whitespace changes.

> - const static struct jz_gpio_bulk_request i2c_pins[] = {
> + static const struct jz_gpio_bulk_request i2c_pins[] = {

Quite surprising - but that still was valid C - just type for example:

int typedef (*func(const char op))(int a, int b[static const a = 3]);

  Ralf

<Prev in Thread] Current Thread [Next in Thread>
  • Re: [PATCH 2/7] MIPS: static should be at beginning of declaration, Ralf Baechle <=